Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: website lint script now lints its 'lib' directory after it was previously eslintignored #1770

Merged
merged 5 commits into from
Aug 19, 2022
Merged

fix: website lint script now lints its 'lib' directory after it was previously eslintignored #1770

merged 5 commits into from
Aug 19, 2022

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Aug 18, 2022 •
edited
Loading

@gobengo gobengo linked an issue Aug 18, 2022 that may be closed by this pull request
website package lint script doesn't run against ./lib dir because of .eslintignore #1762
Closed
@gobengo gobengo requested a review from alanshaw August 18, 2022 23:30
@github-actions
Copy link
Contributor

Website preview 🔗✨

build log

@gobengo gobengo requested a review from yusefnapora August 18, 2022 23:37
yusefnapora
yusefnapora approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍

@gobengo gobengo merged commit 78f0c71 into main Aug 19, 2022
@gobengo gobengo deleted the 1762-website-package-lint-script-doesnt-run-against-lib-dir-because-of-eslintignore branch August 19, 2022 17:14
@github-actions github-actions bot mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

website package lint script doesn't run against ./lib dir because of .eslintignore
2 participants
@gobengo @yusefnapora