-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upload and pin table refactor #2018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upload-and-pin-table-refactor
…upload-and-pin-table-refactor
…plement table cell components.
…upload-and-pin-table-refactor
flea89
reviewed
Oct 14, 2022
flea89
reviewed
Oct 14, 2022
packages/website/components/account/filesManager/uploadsTable.js
Outdated
Show resolved
Hide resolved
flea89
reviewed
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some early feedback, while I go through the uploadsTable.js
packages/website/components/account/filesManager/cellRendererComponents/cidCell.js
Show resolved
Hide resolved
packages/website/components/account/filesManager/cellRendererComponents/storageProvidersCell.js
Show resolved
Hide resolved
packages/website/components/account/filesManager/cellRendererComponents/uploadStatusCell.js
Show resolved
Hide resolved
packages/website/components/account/filesManager/cellRendererComponents/uploadStatusCell.js
Show resolved
Hide resolved
packages/website/components/account/filesManager/cellRendererComponents/uploadStatusCell.js
Show resolved
Hide resolved
packages/website/components/account/filesManager/fileRowItem.js
Outdated
Show resolved
Hide resolved
flea89
reviewed
Oct 14, 2022
flea89
reviewed
Oct 14, 2022
flea89
reviewed
Oct 14, 2022
packages/website/components/account/filesManager/uploadsTable.js
Outdated
Show resolved
Hide resolved
…torage/web3.storage into fix/upload-and-pin-table-refactor
…torage/web3.storage into fix/upload-and-pin-table-refactor
…n the Uploads table.
flea89
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @joshJarr ! Let's get this out.
This was referenced Oct 17, 2022
joshJarr
pushed a commit
that referenced
this pull request
Oct 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.27.0](website-v2.26.0...website-v2.27.0) (2022-10-17) ### Features * status docs ([#1937](#1937)) ([5fde787](5fde787)) ### Bug Fixes * no more request storage in docs ([#2029](#2029)) ([59715d9](59715d9)) * upload and pin table refactor ([#2018](#2018)) ([cbfe9d7](cbfe9d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vasco-santos
pushed a commit
that referenced
this pull request
Feb 28, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.1](web3.storage-v4.5.0...web3.storage-v4.5.1) (2023-02-28) ### Bug Fixes * set client default chunk size to 50MB ([#2227](#2227)) ([e34c2ac](e34c2ac)) * upload and pin table refactor ([#2018](#2018)) ([cbfe9d7](cbfe9d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Refactoring the table renderer for uploads and pins.
TODO: