fix: stop creating a Stripe account during web3.storage account creation #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-schneid
force-pushed
the
2225-remove-code-that-automatically-signs-up-new-user-to-free-tier
branch
3 times, most recently
from
96488f6 to
bdb8298
Compare
e-schneid
force-pushed
the
2225-remove-code-that-automatically-signs-up-new-user-to-free-tier
branch
from
bdb8298 to
240b2fb
Compare
gobengo
approved these changes
Mar 10, 2023
e-schneid
deleted the
2225-remove-code-that-automatically-signs-up-new-user-to-free-tier
branch
|
This is tested in staging by creating a new account and confirming that there is no corresponding customer being create in Stripe. For manual regression testing:
|
e-schneid
pushed a commit
that referenced
this pull request
Mar 13, 2023
🤖 I have created a release *beep* *boop* --- ## [7.15.2](api-v7.15.1...api-v7.15.2) (2023-03-10) ### Bug Fixes * stop creating a Stripe account during web3.storage account creation ([#2226](#2226)) ([425ac5c](425ac5c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2225
This eliminates a race condition causing the creation of multiple customers in Stripe. New customers are now treated as if they're in the free tier without actually giving them a stripe customer.