Fix towei scientific notation

packages/web3-errors/CHANGELOG.md

@@ -166,4 +166,8 @@ Documentation:
 
 -   Fixed grammar and spelling in `transactionTimeoutHint` (#6559)
 
-## [Unreleased]
+## [Unreleased]
+
+### Added 
+
+- Add new `InvalidNumberDecimalPrecisionLossError` (#6908)

packages/web3-errors/src/error_codes.ts

@@ -155,6 +155,7 @@ export const ERR_INVALID_LARGE_VALUE = 1011;
 export const ERR_INVALID_BLOCK = 1012;
 export const ERR_INVALID_TYPE_ABI = 1013;
 export const ERR_INVALID_NIBBLE_WIDTH = 1014;
+export const ERR_INVALID_NUMBER_DECIMAL_PRECISION_LOSS = 1015;
 
 // Validation error codes
 export const ERR_VALIDATION = 1100;

packages/web3-errors/src/errors/utils_errors.ts

@@ -32,6 +32,7 @@
 	ERR_INVALID_TYPE_ABI,
 	ERR_INVALID_UNIT,
 	ERR_INVALID_UNSIGNED_INTEGER,
+	ERR_INVALID_NUMBER_DECIMAL_PRECISION_LOSS
 } from '../error_codes.js';
 import { InvalidValueError } from '../web3_error_base.js';
 
@@ -146,3 +147,11 @@
 		super(value, 'components found but type is not tuple');
 	}
 }
+
+export class InvalidNumberDecimalPrecisionLossError extends InvalidValueError {
+	public code = ERR_INVALID_NUMBER_DECIMAL_PRECISION_LOSS;
+
+	public constructor(value: number) {
+		super(value, 'value is too small to be represented accurately, use bigInt or string instead.');
+	}
+}

packages/web3-utils/CHANGELOG.md

@@ -205,4 +205,12 @@ Documentation:
 
 - fixed erroneous parsing of big numbers in the `toNumber(...)` function (#6880)
 
-## [Unreleased]
+## [Unreleased]
+
+### Fixed
+
+- `toWei` support numbers in scientific notation #6908
+
+### Added
+
+- `toWei` add warning when using large decimals that may cause precision loss #6908

packages/web3-utils/src/converters.ts

@@ -41,6 +41,7 @@
 	InvalidBytesError,
 	InvalidNumberError,
 	InvalidUnitError,
+	InvalidNumberDecimalPrecisionLossError
 } from 'web3-errors';
 import { isUint8Array } from './uint8array.js';
 
@@ -411,7 +412,8 @@
  */
 export const toNumber = (value: Numbers): number | bigint => {
 	if (typeof value === 'number') {
-            if (value > 1e+20) {
+			if (value > 1e+20) {
+				console.warn('Warning: Using type `number` with values that are large or contain many decimals may cause loss of precision, it is recommended to use type `string` or `BigInt` when using conversion methods')
                 // JavaScript converts numbers >= 10^21 to scientific notation when coerced to strings,
                 // leading to potential parsing errors and incorrect representations.
                 // For instance, String(10000000000000000000000) yields '1e+22'.
@@ -551,17 +553,31 @@
 	if (!denomination) {
 		throw new InvalidUnitError(unit);
 	}
+	let parsedNumber = number;
+	if (typeof parsedNumber === 'number'){
+		if (parsedNumber  < 1e-15){
+			console.warn('Warning: The type `numbers` that are large or contain many decimals may cause loss of precision, it is recommended to use type `string` or `BigInt` when using conversion methods')
+			throw new InvalidNumberDecimalPrecisionLossError(number as number);
+		}
+		if (parsedNumber > 1e+20) {
+			console.warn('Warning: Using type `number` with values that are large or contain many decimals may cause loss of precision, it is recommended to use type `string` or `BigInt` when using conversion methods')
 
+			parsedNumber =  BigInt(parsedNumber);
+		}
+	}
+
+	parsedNumber = typeof number === 'number' ? number.toLocaleString('fullwide', {useGrouping: false, maximumFractionDigits: 20}) : number;
 	// if value is decimal e.g. 24.56 extract `integer` and `fraction` part
 	// to avoid `fraction` to be null use `concat` with empty string
 	const [integer, fraction] = String(
-		typeof number === 'string' && !isHexStrict(number) ? number : toNumber(number),
+		typeof parsedNumber === 'string' && !isHexStrict(parsedNumber) ? parsedNumber : toNumber(parsedNumber),
 	)
 		.split('.')
 		.concat('');
 
 	// join the value removing `.` from
 	// 24.56 -> 2456
+
 	const value = BigInt(`${integer}${fraction}`);
 
 	// multiply value with denomination

packages/web3-utils/test/fixtures/converters.ts

@@ -285,9 +285,14 @@ export const fromWeiValidData: [[Numbers, EtherUnits], string][] = [
     [[1.9999999999999991611392e+22, 'ether'], '19999.999999999991611392'],
 ];
 
-export const toWeiValidData: [[Numbers, EtherUnits], string][] = [
+export const toWeiValidData: [[Numbers, EtherUnits], Numbers][] = [
 	...conversionBaseData,
 	[['255', 'wei'], '0xFF'],
+	[['255', 'wei'], '0xFF'],
+	[['100000000000', 'ether'], 0.0000001],
+	[['1000000000', 'ether'], 0.000000001],
+	[['1000000', 'ether'], 0.000000000001]
+
 ];
 
 export const fromWeiInvalidData: [[any, any], string][] = [
@@ -310,6 +315,7 @@ export const toWeiInvalidData: [[any, any], string][] = [
 	[[{}, 'kwei'], 'value "{}" at "/0" must pass "number" validation'],
 	[['data', 'kwei'], 'value "data" at "/0" must pass "number" validation'],
 	[['1234', 'uwei'], 'Invalid value given "uwei". Error: invalid unit.'],
+	[[0.0000000000000000000001, 'ether'], 'value is too small to be represented accurately, use bigInt or string instead.'],
 ];
 export const toCheckSumValidData: [string, string][] = [
 	['0x0089d53f703f7e0843953d48133f74ce247184c2', '0x0089d53F703f7E0843953D48133f74cE247184c2'],