Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python unit tests for form.py #1587

Closed
cch5ng opened this issue Jun 8, 2017 · 1 comment
Closed

add python unit tests for form.py #1587

cch5ng opened this issue Jun 8, 2017 · 1 comment
Assignees
@karlcow
Labels
in progress lang: Python status: needs tests type: bug type: testing

Comments

@cch5ng
Copy link
Contributor

cch5ng commented Jun 8, 2017

some existing functions in form.py are missing unit tests.

should affect https://github.com/webcompat/webcompat.com/blob/master/tests/test_form.py
@karlcow
Copy link
Member

karlcow commented Jun 8, 2017

Thanks a lot @cch5ng.

karlcow referenced this issue Jun 22, 2017
Issue #432 - Derive bug title summary from selected radio choice
af9f3c3
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jun 22, 2017
@karlcow
Issue webcompat#1587 - syntax fixing for comments
eb44591
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jun 22, 2017
@karlcow
Issue webcompat#1587 - Fixes comment syntax
2bb6769 
Also makes get_problem_summary() more explicit with  description and
comments.
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jun 22, 2017
@karlcow
Issue webcompat#1587 - Adds tests for all form.py functions
7e89f42
karlcow added a commit to karlcow/webcompat.com that referenced this issue Jun 22, 2017
@karlcow
Issue webcompat#1587 - Fixes an issue with URL normalization
fb4b297 
Before if by chance in the process we hap an empty url, the code would
fall apart and probably break with a 500. This will not happen anymore.
miketaylr pushed a commit that referenced this issue Jul 7, 2017
Issue #1587. Remove redundant tests and fix expected value post form …
58f8ec2 
…refactor.
miketaylr pushed a commit that referenced this issue Jul 7, 2017
@karlcow
Issue #1587 - syntax fixing for comments
b4f2685
miketaylr pushed a commit that referenced this issue Jul 7, 2017
@karlcow
Issue #1587 - Fixes comment syntax
8fa3ed9 
Also makes get_problem_summary() more explicit with  description and
comments.
miketaylr pushed a commit that referenced this issue Jul 7, 2017
@karlcow
Issue #1587 - Adds tests for all form.py functions
3fd38f5
miketaylr pushed a commit that referenced this issue Jul 7, 2017
@karlcow
Issue #1587 - Fixes an issue with URL normalization
e466505 
Before if by chance in the process we hap an empty url, the code would
fall apart and probably break with a 500. This will not happen anymore.
miketaylr pushed a commit that referenced this issue Jul 7, 2017
Issue #1587 - Remove redundant tests and fix expected value (after me…
b5c79c4 
…rge conflict).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
in progress lang: Python status: needs tests type: bug type: testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karlcow @cch5ng