-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design "global issues view" #169
Comments
Great points @miketaylr. Thank you for the feedback. A couple questions - Also for everyone - Github has a ton of filters, sort and search abilities. Leaving out PRs, I found at least these below. Which filters/sort are most important for the Webcompat community?
New undercooked design below
|
Just a terrible typo. :/ s/did/dig/. typing |
As far as capabilities go, we can choose. It could be anything as simple as plain text search over all issues to the advanced github search syntax. That's all supported by the Search API: https://developer.github.com/v3/search/. It can actually be both at once as well. I might be talking myself out of my earlier comment.
+1. I imagine clicking "firefox" would populate the search box with |
I'm curious to hear @karlcow's opinion on this. For me, probably all the options listed are useful, depending on what I'm trying to do (probably less so for Assignee--but if we expose that in the issue someone could click that and we could kick off a filter of that). |
Maybe two issues per lines ?
Maybe add background-color instead of border-color and add on top/right corner an icon (plus and minus) ? Add a new select box to selecte the number of issues par pages ? Very good job @calexity, like it. |
Plugging brain. bzzzt. reading again the full thread. 🕐 🕑 🕒 sound of 🚜 up there. ok. Let's see. Maybe a way to think about it is to ignore what github proposes and think what I would like to see there. Then see if it's doable with github tools as they are. I can imagine two states:
I'm thinking about the non logged users now and below. So indeed this top dashboard. Want to be clickable. I might want to be able to search by domain name. I might be a reverse domain search to make it easier (to think). Basically, if I'm coming for the first time, I might want to know if someone has already reported my bug for this site. Typing the domain name could bring all the issues related to that domain. Where it will be wholly not effective is that in our current dependency of github. The domain name is in the body, which means there is no search feature from github for it. Though we could create indexes on webcompat side. We can parse the current bugs and all new bugs could feed the DB creating an index. so someone typing Other information we have: number of comments, last updated date. I wonder if there is a karma that could be computed for each bugs: Pampered (already a lot of activity)/ Need Love (not that much activity for a long time). This to encourage people to help with old bugs. I will keep this running in my mind for the week-end. Maybe there are more type of users we haven't thought about and that could influence the design. For logged in users. I have the feeling the page should be entirely different but that's for version-n++++ |
BTW, I was just wondering if we are talking about sorting (order in which things come) or about filtering (reducing the set of things which are visible)? Also an idea which just popped up in my silly mind. @calexity Do you know the "Developer Toolbar" in Tools -> Web Developer in Firefox. It's a very interesting system based on command on a combination of typing ahead, commands and suggestive placeholders. It's really well done in terms of UX. Now let's say the user put the cursor in the search bar: what could happen for guidance? Imagine for example something like… Here I will use paranthesis to express gray.
|
Good point. We can ask the API for issues to be paginated, rather than display everything at once.
Nah, you can do a plain text search over issues. See https://developer.github.com/v3/search/#issue-search-example and https://github.com/webcompat/web-bugs/search?q=google.com&type=Issues&utf8=%E2%9C%93. |
Hey @karlcow @magsout @miketaylr et al - I moved the screenshot to Invision so it's easier to comment on pieces of the design. Can everyone see and comment on this? I added questions there. I can actually link together a small prototype of how it might work and we can punt it out on Twitter and the mailing list for feedback. https://projects.invisionapp.com/share/EC1E27VFU#/screens/38185232/comments |
Here's an example of what Susan (@karlcow's persona) might do when she lands on this page: Prototype will move on it's own right now. |
Thank you all for the feedback @magsout @miketaylr @karlcow I made some changes on Invision (you can toggle comments on/off on bottom right of screen) I also walked through some of Karl's use cases. Those were extremely helpful. Karl - am I missing key activities? I turned off auto forward, just page through using right arrow Paul, the newcomer scoping out webcompat Aminata, the journalist looking for a specific site Ahmed, the web dev looking for help with web compatibility Should we tweet or send this out for comments by the community? Is it easy to understand? |
@calexity @miketaylr
Uses case are easy to understand. Very good job @calexity |
I am missing the pagination! Thanks @magsout I think it's too much to I will add it on the top right.
|
@calexity wonderful! This is good stuff, and good materials to help us understand. Nice! I wonder if we should ask to the people who helped us on bugs in the past what they think about this tool and it would improve (or not) their own work. About tweeting. Yup. |
Sent first version. Tell me what do you think @karlcow @miketaylr @calexity @tagawa Dropdown need JS to work. Add Some dropdown are different than mockup of @calexity (show number per page and big dropdown). Filters are below the big dropdown because there is still not enough space Open to any feedback you all have. |
@magsout I see your commits, but I can't load the app on my local computer, so I can't see the page yet. I wrote responses to your Invision comments which I hope are helpful...I think we'll have some work to do to optimize this for smaller devices. We might think about an option collapsing the sort/filters to optimize for issue browsing. I'll consider how this might work and post something soon. |
@karlcow no, the documentation is pretty thorough. I'm just inept with computers. I think it's fine if you can all see it. Once it goes to staging, I'll look at it. |
Thanks , fixed and sent.
yes, agree. |
Looking really good @magsout. A couple of minor comments:
|
thanks @tagawa
When status button is-active, there is background-color puts on Button like :hover state. Need more, do you think ? |
I was thinking more this kind of shape (ignore the colours/text), possibly with a slight space between each button: |
I think using "New" instead of "Untriaged" is a great idea. Re: the arrows, I worry that that pattern doesn't signify that it's clickable. Maybe if we leave them disconnected, but just the right side is an arrow it will be fine, which is what I think you are suggesting @tagawa |
Yes, sounds good @calexity, although I'm not pushing hard for this - it was just a thought. |
Good idea. I filed #286 to track that. We should hold off for a few days before we try that as I'm hacking up the Backbone files trying to make them more reusable. |
I've deployed what I've done so far to http://staging.webcompat.com/issues. Note that "team" is hard-coded for now. I need to think how to easily pull that in, I guess issue filer + comment author (minus @webcompat-bot?). This might be something I come back to after doing everything else. I know we're not to the polish phase yet, but the composition looks a little unbalanced. How do we feel about pulling in label bg colors? |
It looks OK. I think I know what you mean about being unbalanced. Maybe a tiny tweak like rounded corners on the right-hand side only could balance the coloured line on the left? For "label bg colors", do you mean the label text should be coloured? I think so but some of them may lack contrast. Another option is coloured text-shadow, or coloured underline, etc. Speaking of contrast, the "Search by keyword" seems much paler than in the design preview and not good for accessibility (or bright sunlight). Maybe we should think about whether we have a minimum contrast across the site to comply with a certain level of WCAG, or if we don't worry about that at this stage. |
Agreed about the unbalance. I notice a couple things we could fix to help this -
I tried a couple ideas (below). I'm not sold on them and am open to other ideas. I think @tagawa's idea to use color text in the labels could be cool. We might have to choose a palette there so they are readable. Daniel - re: contrast - do you mean the contrast of the field color vs adjacent colors or the contrast of the text vs field color is low? I tried a few different ways to render that search box, but couldn't find anything I thought worked better. I think we can easily make that text darker if that will help. Also, do you have any experience with accessibility testing? I'd love to do that for this project. |
@calexity I like first screenshot. I thought about small device like smartphone or phablet. I thought something like, see only the search bar and issue . The user would have to click on filter button to display the filters (select box and sate issue). |
@magsout that makes a lot of sense to me. I think we'll have to use a different background color (to distinguish from the top nav bar). I had done this design before, which I can't find in this thread. My only concern is putting too many filters in one dropdown. |
Agreed
and in fact http://staging.webcompat.com/issues is done like you screenshot. This idea all together in a button will add elements later and especially space-saving high on small screens. |
Did we ever come up with a design for pagination? I think I'd like to deploy this feature in smaller chunks--if we have a frontend for pagination then we could release an issues page with all the filter buttons (and then incrementally add the sorting, search, etc.) |
"simplest" version gets my vote because a) pagination on top aligned with "Show 25" and "Newest", and b) easiest (and therefore fastest) to implement. The others look good too if we could make it nicely responsive for wide screens. |
like @tagawa I would target the simplest possible. We haven't released anything outside of staging on the main site. I'm a bit worried that it will bite us at a point. Basically small increments, rinse and repeat would help us to learn. Specifically at this stage where the number of users is small. Deploy more often, fail fast, improve. Too many things are blocked in the pipe which are not related to the design. |
Which things are blocked specifically? We have one changeset related to caching, which is good for us because it saves us on API requests. But not really a user-facing feature. And we have a few changesets related to documentation. The whole point of asking for a design on pagination is precisely so we can release a smaller increment:
Patches welcome. :) |
Just wanted to add that the 2nd design looks like an awesome tablet-experience layout. Something to revisit maybe. |
@miketaylr add pagination |
We can use it for tablet-experience, and keep actual design for wide device. Just thinking about small device |
@miketaylr said:
Yes my point. not related to the design. ^_^ needs discussions but elsewhere. |
Maybe we can close that looong issue ? And re open another for tablet/mobile-experience ? |
👍 But up to @calexity, I think. |
Yes that sounds a very good idea @magsout And we can interlink them anyway. |
Sure thing - done. #349 |
Design view for https://github.com/webcompat/web-bugs/issues?state=open
The text was updated successfully, but these errors were encountered: