Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Labels' Save & Close button is not working #1696

Closed
softvision-sergiulogigan opened this issue Aug 2, 2017 · 3 comments
Closed

The Labels' Save & Close button is not working #1696

softvision-sergiulogigan opened this issue Aug 2, 2017 · 3 comments
Assignees
@miketaylr
Labels
status: needs tests type: bug

Comments

@softvision-sergiulogigan
Copy link
Collaborator

Environment:
Browser / Version: Chrome 59.0.3071.115 (Desktop), Firefox 54.0.1 Release (Desktop)
Operating System: Windows 10

Steps to Reproduce:

  1. Navigate to: (eg.)https://webcompat.com/issues/8621
  2. Click on the Gear icon, on the right.
  3. Select some labels.
  4. CLick the Save & Close button.

Expected Behavior:
The Labels list is closed.

Actual Behavior:
Nothing happens.

Notes:

  1. The selected labels are applied.

sv;
@softvision-sergiulogigan
Copy link
Collaborator Author

Might be related to #1680

@miketaylr
Copy link
Member

@sergiorojasa i probably broke this! as a workaround, either hit esc or click outside the label editor and it will save label edits. Will fix today. 🙈

@miketaylr miketaylr self-assigned this Aug 2, 2017
miketaylr pushed a commit that referenced this issue Aug 2, 2017
Issue #1696. Unbreak Save & close label editor button.
8236a9d
brizental added a commit that referenced this issue Aug 3, 2017
@brizental
Merge pull request #1698 from /issues/1696/1
5e8337c 
Issue #1696. Unbreak Save & close label editor button.
@karlcow karlcow mentioned this issue Aug 3, 2017
Closed
zoepage pushed a commit that referenced this issue Aug 4, 2017
@brizental @zoepage
Merge pull request #1698 from /issues/1696/1
63e0d24 
Issue #1696. Unbreak Save & close label editor button.
@gvanwaelvelde
Copy link

This issue still exists for me in Firefox 54, Firefox 57, Google Chrome 59 and Google Chrome Canary 62 on Android 6.0.1

@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
status: needs tests type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miketaylr @gvanwaelvelde @softvision-sergiulogigan @brizental