Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Time dependent test failure #1867

Closed
karlcow opened this issue Nov 12, 2017 · 1 comment
Closed

[Dashboard] Time dependent test failure #1867

karlcow opened this issue Nov 12, 2017 · 1 comment
Assignees
@karlcow
Labels
scope: dashboard type: testing
Milestone
NeedsTriage Issue...

Comments

@karlcow
Copy link
Member

karlcow commented Nov 12, 2017

One test was working because it was uncannily in the right time gap.
It has to be fixed.
@karlcow karlcow self-assigned this Nov 12, 2017
@karlcow karlcow added this to the NeedsTriage Issues Dashboard milestone Nov 12, 2017
karlcow added a commit to karlcow/webcompat.com that referenced this issue Nov 12, 2017
@karlcow
Issue webcompat#1867 - Fixes the time dependent test failure.
ab6e920 
- Adds a more generic function to compute the threshold for time.
- Makes the fixture in the past so we don't run in an uncanny situation.
- Modifies the patch so it mocks the return value for the control date.
@karlcow
Copy link
Member Author

karlcow commented Nov 12, 2017

Fixed by #1868

miketaylr pushed a commit that referenced this issue Nov 13, 2017
Merge pull request #1868 from karlcow/1867/1
d593179 
Fixes #1867 - Fixes time dependent test failure.
@karlcow karlcow closed this as completed Nov 14, 2017
miketaylr pushed a commit that referenced this issue Nov 30, 2017
@karlcow @miketaylr
Issue #1867 - Fixes the time dependent test failure.
c131b42 
- Adds a more generic function to compute the threshold for time.
- Makes the fixture in the past so we don't run in an uncanny situation.
- Modifies the patch so it mocks the return value for the control date.
miketaylr pushed a commit that referenced this issue Nov 30, 2017
@karlcow @miketaylr
Issue #1867 - Fixes the time dependent test failure.
817888f 
- Adds a more generic function to compute the threshold for time.
- Makes the fixture in the past so we don't run in an uncanny situation.
- Modifies the patch so it mocks the return value for the control date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlcow karlcow

Labels
scope: dashboard type: testing
Projects
None yet
Milestone
NeedsTriage Issues Dashboard
Development

No branches or pull requests
2 participants
@karlcow @zoepage