Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Device" term is used when "OS" term is more appropriate #3041

Closed
cipriansv opened this issue Oct 25, 2019 · 2 comments
Closed

"Device" term is used when "OS" term is more appropriate #3041

cipriansv opened this issue Oct 25, 2019 · 2 comments

Comments

@cipriansv
Copy link
Collaborator

cipriansv commented Oct 25, 2019

Environment:
Browser / Version: Firefox Nightly 72.0a1 (2019-10-24)
Operating System: Ubuntu 18.04.3 LTS

Steps to Reproduce:

  1. Navigate to https://staging.webcompat.com/issues/new
  2. Fill in the form and reach the ”Did you encounter the issue on this device (Linux)”… section
  3. Observe the section’s question.

Expected Behavior:
”Did you encounter the issue on this OS (Linux) using this browser(Firefox)?" should be displayed.

Actual Behavior:
”Did you encounter the issue on this device (Linux) using this browser(Firefox)?" is displayed

Notes:

  1. Screen capture attached.
  2. The issue is also reproducible on Chrome 78.0.3904.70
  3. The issue is also reproducible for the next section - “What browser and device were you using when the issue encountered?”

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv;

Screenshot from 2019-10-25 14-31-52

@miketaylr
Copy link
Member

Let's let @mcroud comment here.

@DPX-designer
Copy link
Collaborator

This is a good observation, I suppose working on the mobile experience first biased my thinking towards "devices".

Holding up my phone I asked a family member what "device" it was, they responded "mobile phone", I then asked them what operating system it was, the response was "Google" - certainly more accurate as it's an Android.
I originally suspected that 'device' would appeal to a greater audience but it may provide weaker information so let's go with Operating system 👍
Thanks!

@miketaylr miketaylr self-assigned this Nov 7, 2019
miketaylr pushed a commit that referenced this issue Nov 7, 2019
Note: it seems like FormWizard.device wasn't even used -- it was populated
but never sent to GitHub. It was sending FormWizard.os all along.
@karlcow karlcow closed this as completed in d61e8a0 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants