Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple confirm clicks log multiple issues #3050

Closed
softvision-sergiulogigan opened this issue Oct 25, 2019 · 5 comments
Closed

Multiple confirm clicks log multiple issues #3050

softvision-sergiulogigan opened this issue Oct 25, 2019 · 5 comments

Comments

@softvision-sergiulogigan
Copy link
Collaborator

Environment:
Browser / Version: Firefox Nightly 72.0a1 (2019-10-24)
Operating System: Windows 10 Pro

Steps to Reproduce:

  1. Navigate to https://staging.webcompat.com/issues/new
  2. Follow the entire report flow.
  3. Click multiple times on the "Send Report" button.

Expected Behavior:
The report is only sent once.

Actual Behavior:
The report is duplicated.

Notes:

  1. Screenshot attached.
  2. I was able to duplicate a report 70 times in 10 seconds (or less) - https://github.com/webcompat/webcompat-tests/issues?utf8=%E2%9C%93&q=www.pisicamare2154.com

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov
@cipriansv

image

@miketaylr
Copy link
Member

I was able to duplicate a report 70 times in 10 seconds (or less) - https://github.com/webcompat/webcompat-tests/issues?utf8=%E2%9C%93&q=www.pisicamare2154.com

You are a monster.

@miketaylr
Copy link
Member

Yikes, what.

@miketaylr
Copy link
Member

This one seems particularly bad @bacharakis. It does not reproduce in form v1.

@johngian
Copy link
Contributor

I managed to reproduce this in form v1 as well. Should we try to fix it for all versions?

image

@miketaylr
Copy link
Member

I managed to reproduce this in form v1 as well.

Well, that's cool I guess. Not a new regression.

The good news is I don't think we've ever really seen this (at least, as a spam tactic). Should probs fix this everywhere (or just fix it once on the backend).

miketaylr pushed a commit that referenced this issue Oct 28, 2019
To prevent spamming the button and filing lots of bugs.
@miketaylr miketaylr self-assigned this Oct 28, 2019
miketaylr pushed a commit that referenced this issue Oct 29, 2019
Issue #3050 - Disable submits on form submit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants