-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make anonymous reporting configurable #3132
Comments
I'm gonna stick this in environment.py so we can test out staging differently than production, so we'll need to remember to add |
…reports If not set to something truthy, return a 400
I think to keep things simple, let's limit the scope of this bug to the backend. Not sure it's worth making the frontend as flexible right now -- but when we need to re-enable it, here's the relevant patch to study: 524e130 |
I just went and made the changes, it only took 5 minutes. |
(I forgot to fix this earlier, oops)
In #3121 and other places I was pretty hacky about turning this off (just commenting it out, or ripping things out).
I think we could have a config option in https://github.com/webcompat/webcompat.com/blob/master/config/__init__.py, something like
ENABLE_ANONYMOUS_REPORTS
and set it toFalse
.Then we can update tests to handle both scenarios, and check the config option before returning
400
here: https://github.com/webcompat/webcompat.com/blob/master/webcompat/issues.py#L27-L34.I guess we could also control the button's state and text in the template too.
The text was updated successfully, but these errors were encountered: