Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Unable to close “Learn more”/“What is a web compatibility issue” popups using “Esc” key #3397

Closed
softvision-oana-arbuzov opened this issue Jul 16, 2020 · 1 comment
Closed

[A11Y] Unable to close “Learn more”/“What is a web compatibility issue” popups using “Esc” key #3397

softvision-oana-arbuzov opened this issue Jul 16, 2020 · 1 comment
Assignees
@miketaylr
Labels
a11y

Comments

@softvision-oana-arbuzov
Copy link
Member

softvision-oana-arbuzov commented Jul 16, 2020 •
edited
Loading

Browser / Version: Firefox Nightly 80.0a1 (2020-07-15)
Operating System: Windows 10 Pro

Steps to Reproduce:

  1. Navigate to https://webcompat.com/issues/new
  2. Using "Tab" key, navigate to the URL field and fill it in.
  3. Using "Tab" key, navigate to "Confirm" button.
  4. Using "Tab" key, navigate to "Learn more about web compatibility" link.
  5. Using "Enter" key, activate the popup.
  6. Using "Esc" key, try to dismiss the popup.
  7. Observe behavior.

Expected Behavior:
The popup is dismissed.

Actual Behavior:
Nothing happens, the popup is not dismissed.

Notes:

  1. Screenshot attached.
  2. The issue is also reproducible for "Learn more" > "Public Reports" popup.
    image
    image
  3. According to "Inspector>Accessibility" tab, "X" button "must be focusable and should have interactive semantics".
    image

Watchers:
@softvision-oana-arbuzov
@cipriansv
@miketaylr miketaylr self-assigned this Aug 7, 2020
miketaylr pushed a commit that referenced this issue Aug 7, 2020
Issue #3397 - Part 2. Close an open modal when Escape key is pressed
fffe1aa
miketaylr pushed a commit that referenced this issue Aug 7, 2020
Issue #3397 - Part 3. Add functional tests for Esc to close modals
f87ef78
miketaylr pushed a commit that referenced this issue Aug 8, 2020
Issue #3397 - Part 2. Close an open modal when Escape key is pressed
7c33035
miketaylr pushed a commit that referenced this issue Aug 8, 2020
Issue #3397 - Part 3. Add functional tests for Esc to close modals
2711b33
miketaylr pushed a commit that referenced this issue Aug 17, 2020
Issue #3397 - Part 4. s/what-is-webcompat/what-is-compat/
ad0b211
miketaylr pushed a commit that referenced this issue Aug 17, 2020
Issue #3397 - Part 2. Close an open modal when Escape key is pressed
c12fac5
miketaylr pushed a commit that referenced this issue Aug 17, 2020
Issue #3397 - Part 3. Add functional tests for Esc to close modals
191673d
miketaylr pushed a commit that referenced this issue Aug 17, 2020
Issue #3397 - Part 4. s/what-is-webcompat/what-is-compat/
3204668
ksy36 added a commit that referenced this issue Aug 17, 2020
@ksy36
Merge pull request #3446 from /issues/3397/1
f130ccd 
Fixes #3391 - Add ability to close modals with Esc key
@softvision-oana-arbuzov
Copy link
Member Author

I can confirm this is fixed.

Tested with:
Browser / Version: Firefox Nightly 82.0a1 (2020-09-16), Chrome 85.0.4183.102
Operating System: Windows 10 Pro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
a11y
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @softvision-oana-arbuzov