-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook accepted: invalid/incomplete milestones should add comment rather than replace issue body #3467
Comments
miketaylr
pushed a commit
that referenced
this issue
Aug 31, 2020
… for invalid and incomplete issues
miketaylr
pushed a commit
that referenced
this issue
Aug 31, 2020
(This helps me test it later, and it seems good anyways)
miketaylr
pushed a commit
that referenced
this issue
Aug 31, 2020
miketaylr
pushed a commit
that referenced
this issue
Aug 31, 2020
miketaylr
pushed a commit
that referenced
this issue
Sep 1, 2020
miketaylr
pushed a commit
that referenced
this issue
Sep 1, 2020
miketaylr
pushed a commit
that referenced
this issue
Sep 1, 2020
miketaylr
pushed a commit
that referenced
this issue
Sep 1, 2020
miketaylr
pushed a commit
that referenced
this issue
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just realized that we probably don't want to replace the body of an accepted invalid or incomplete issue. Rather, we want to add the invalid/incomplete message as a comment. If we re-train our ML bot, we're going to skew results. And we'll also lose possibly interesting reports for future analysis.
For rejected issues, we absolutely do not want report body content -- these are different though.
The text was updated successfully, but these errors were encountered: