Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search is broken #3639

Closed
magsout opened this issue Nov 7, 2021 · 4 comments
Closed

search is broken #3639

magsout opened this issue Nov 7, 2021 · 4 comments

Comments

@magsout
Copy link
Member

magsout commented Nov 7, 2021

I'm unable to search anything in webcompat.com every times I get this error image

@noreplyblitzline

This comment was marked as off-topic.

@karlcow
Copy link
Member

karlcow commented Nov 8, 2021

🤔 So on Firefox Nightly Fresh Profile, no addons.
I get with the search in the homepage

Capture d’écran 2021-11-08 à 09 24 23

Then this is the results I got from the All issues page.

Capture d’écran 2021-11-08 à 09 26 04

OK this is happening only when logged in.

This is working:

https://webcompat.com/issues?page=1&per_page=50&state=open&stage=all&sort=created&direction=desc&q=doctolib%20is%3Aissue

Changing &q=doctolib by &q=doctolib%20is%3Aissue fixes it.

It needs to be adjusted.
https://github.com/webcompat/webcompat.com/blob/030c2613d9842379557e74aa6f16c2e59dac2e2f/webcompat/static/js/lib/issue-list.js

Also it means that all the Auth tests are "not testing the right thing anymore" in the sense that they are in a scenario which is not the same. Probably tests need to be fixed in a separate bug.

@karlcow
Copy link
Member

karlcow commented Nov 8, 2021

This is a regression from #3629

@ksy36
Copy link
Contributor

ksy36 commented Nov 9, 2021

Thanks @magsout :)
Found this https://docs.github.com/en/rest/reference/search#search-issues-and-pull-requests:

Note: For user-to-server GitHub App requests, you can't retrieve a combination of issues and pull requests in a single query. Requests that don't include the is:issue or is:pull-request qualifier will receive an HTTP 422 Unprocessable Entity response. To get results for both issues and pull requests, you must send separate queries for issues and pull requests. For more information about the is qualifier, see "Searching only issues or pull requests."

Will add this parameter in #3641

@karlcow karlcow closed this as completed in 60c588e Nov 9, 2021
karlcow added a commit that referenced this issue Nov 9, 2021
Fixes #3639 - Add a required parameter to request only issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants