Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retina image support for contributors page #428

Closed
miketaylr opened this issue Dec 3, 2014 · 5 comments
Closed

Retina image support for contributors page #428

miketaylr opened this issue Dec 3, 2014 · 5 comments
Labels
prio: good first bug
Milestone
Unprioritized issues

Comments

@miketaylr
Copy link
Member

The images on /contributors look blurry on retina devices.
@miketaylr miketaylr added this to the Unprioritized issues milestone Dec 3, 2014
@magsout
Copy link
Member

magsout commented Dec 15, 2014

how to improve this? make screenshot from a retina, and increase the resolution on the site?

@miketaylr
Copy link
Member Author

Yeah, I'm not exactly sure what the state of the art is here. We could use srcset and 2x images, etc, but I don't know what support looks like for that yet. To research.

@magsout
Copy link
Member

magsout commented Feb 26, 2015

@miketaylr you have retina device ? If yes, can you make some screenshot to test ?

@miketaylr
Copy link
Member Author

Yep, I'll take some screenshots on my rMBP.

@miketaylr
Copy link
Member Author

See https://cldup.com/9EM7uge54c-3000x3000.png and https://cldup.com/ai4pDOXye3-3000x3000.png, for example.

miketaylr pushed a commit that referenced this issue Apr 7, 2015
Issue #428 - Replace blurry images with more Retina-friendly ones.
56ec2b6
@magsout magsout closed this as completed in e3acc54 Apr 7, 2015
@karlcow karlcow mentioned this issue Jan 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: good first bug
Projects
None yet
Milestone
Unprioritized issues
Development

No branches or pull requests
2 participants
@miketaylr @magsout