-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Caching is broken on webcompat.com #590
Comments
It looks like the source of the bug is we only do conditional GET for logged in users. If I log in, I get a 304 on 779.json on the 2nd time. So the fix would be to incorporate |
OK in theory that's supposed to be happening here: https://github.com/webcompat/webcompat.com/blob/master/webcompat/issues.py#L31 |
Ah, I think I see the bug. |
Which will be merged with the AUTH_HEADERS and sent to github.
This allows us to send conditional GET requests based on eTag in the case of un-authed requests.
@miketaylr did a good job for the JSON part. We need to fix the caching story for HTML too. |
We must have made a modification at a point which has broken our cache. We need to figure it out :)
So far just a preview. I tried to navigate a bit more and I get only "200" except for github and google which are sending the right things for their own parts independent of webcompat.
Let's try with 773
/issues/773
No Etag sent by the server, no caching information.So the second time we hit it it does the same thing again.
Hmm… I wonder if we butchered all of that when we decided to put under https?
The text was updated successfully, but these errors were encountered: