run.py depends on cat, why?

[hallvors]

Trying to run run.py on Windows fails because it tries to call the cat command on line 63:

req = subprocess.check_output(["cat", "requirements.txt"]).splitlines()

The easiest workaround is to do run.py -t to launch "test mode", and I guess we'll never ever run this on a system where 'cat' is not available for production. But why depend on cat in the first place?

for req in open("requirements.txt"):
    pkg_resources.require(req)

should do, I think.

[karlcow]

@hallvors is talking about

webcompat.com/run.py

Lines 57 to 71 in 2936db3

	def check_pip_deps():
	'''Check installed pip dependencies.
	Make sure that the installed pip packages match what is in
	requirements.txt, prompting the user to upgrade if not.
	'''
	req = subprocess.check_output(["cat", "requirements.txt"]).splitlines()
	try:
	pkg_resources.require(req)
	except VersionConflict as e:
	print(DEPS_VERSION_HELP % e)
	except DistributionNotFound as e:
	print(DEPS_NOTFOUND_HELP % e)
	else:
	return True

[karlcow]

That was my commit 7252891

And yes good comment. Your proposal is a good one. Also possible.

try:
   pkg_resources.require([req for req in open("requirements.txt")])

[hallvors]

Wow, even more brief :)

[miketaylr]

Cool, learned some more Python today. ^_^