Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linting via Travis #860

Closed
miketaylr opened this issue Dec 14, 2015 · 4 comments
Closed

Enable linting via Travis #860

miketaylr opened this issue Dec 14, 2015 · 4 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

eslint + pep8 for now.
@miketaylr miketaylr self-assigned this Dec 14, 2015
@miketaylr
Copy link
Member Author

Probably want to add an .eslintignore file so we're not failing on minified libs and the like.

@miketaylr miketaylr mentioned this issue Dec 14, 2015
Merged
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. eslint fixes for Gruntfile.js
37e6ff0
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. eslint fixes for grunt-tasks/*
1a6d060
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. Add missing require/module global to eslintrc.
7e721f5
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. Fixes for adding mixins to eslint task.
e3d4ed4
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. eslint fixes for adding models directory to grunt task.
908cebe
@miketaylr
Copy link
Member Author

Probably want to add an .eslintignore file so we're not failing on minified libs and the like.

Eh, it's only a few more lines to add what we want for JS. So I did that instead.

@miketaylr
Copy link
Member Author

I'm gonna go with the following pep8 magical incantation to give to travis:

pep8 --ignore=E402 webcompat/ tests/ config.py.example

E402 complains about non-top-level imports, but in certain places we have to wait on the app to be initialized before importing junk.

miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. Minor style tweaks to make pep8 happy.
7c0a864
miketaylr pushed a commit that referenced this issue Dec 14, 2015
Issue #860. Add pep8 linting to .travis.yml
af0b73f 
(JS is part of grunt)
@karlcow
Copy link
Member

karlcow commented Dec 14, 2015

yeah \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow