Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 413 gracefully when reporting a bug #994

Closed
miketaylr opened this issue Apr 5, 2016 · 5 comments
Closed

Handle 413 gracefully when reporting a bug #994

miketaylr opened this issue Apr 5, 2016 · 5 comments
Assignees
@miketaylr
Milestone
Fix Mobile Screen...

Comments

@miketaylr
Copy link
Member

Right now if you try to upload a massive image, you get redirected to an ugly default NGINX 413 request entity too large page.

We need to instead of redirecting to that page, display a flash error and let the user select a smaller image.
#993 is related, but this bug is what happens in case that fails (maybe not possible, but we should cover both the front and back end experiences).
@miketaylr
Copy link
Member Author

To fix this today, we would just need a 413 error handler. But maybe we should wait for #958 to land.

We can ship #996 and it will solve most of the problem for us.

@miketaylr
Copy link
Member Author

I just hit this again, so I want to fix it ASAP. Right now you get a flash message that says something went wrong (which you probably wont' see, see #1010) and then the spinner never goes away.

So, we should have a useful flash message, and the spinner should go away.

@miketaylr
Copy link
Member Author

And maybe #996 isn't working for the add-on screenshot use case. To investigate.

@miketaylr
Copy link
Member Author

And maybe #996 isn't working for the add-on screenshot use case. To investigate.

Really #1012 should cover that.

miketaylr pushed a commit that referenced this issue Apr 22, 2016
Issue #994. Show image preview for non PNG images as well.
7c25746
miketaylr pushed a commit that referenced this issue Apr 22, 2016
Issue #994. Fix selector so help message can be removed.
8096be6
miketaylr pushed a commit that referenced this issue Apr 22, 2016
Issue #994. Clear out file input if the image is too big.
68a0558 
Also test that img_too_big isn't true before re-enabling submits.
@miketaylr
Copy link
Member Author

(Just some related frontend tweaks for now)

miketaylr pushed a commit that referenced this issue Apr 23, 2016
Issue #994. Add a 413 handler.
9f8f15f
miketaylr pushed a commit that referenced this issue Apr 23, 2016
Issue #994. Provide a better flash message for 413.
42dd82f 
Also, make sure z-index is higher than the image preview.
miketaylr pushed a commit that referenced this issue Apr 23, 2016
Issue #994. Provide a better flash message for 413.
bb9e9f9 
Also, make sure z-index is higher than the image preview.
miketaylr pushed a commit that referenced this issue Apr 23, 2016
Issue #994. Provide a better flash message for 413.
30d6416 
Also, make sure z-index is higher than the image preview.
@miketaylr miketaylr self-assigned this Apr 23, 2016
miketaylr pushed a commit that referenced this issue Apr 27, 2016
Issue #994. Show image preview for non PNG images as well.
a0d4497
miketaylr pushed a commit that referenced this issue Apr 27, 2016
Issue #994. Clear out file input if the image is too big.
fe269f8 
Also test that img_too_big isn't true before re-enabling submits.
miketaylr pushed a commit that referenced this issue Apr 27, 2016
Issue #994. Provide a better flash message for 413.
253e6fa 
Also, make sure z-index is higher than the image preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
Fix Mobile Screenshots Quality Issues
Development

No branches or pull requests
1 participant
@miketaylr