Fixes #1049. Upload images before form submission. #1053

miketaylr · 2016-05-19T22:00:33Z

No description provided.

(At the time this is called, Pillow doesn't know that we're going to convert the PNG to JPG just yet)

…ion.

miketaylr · 2016-05-19T22:04:44Z

Ah yeah, need to update python tests.

miketaylr · 2016-05-19T22:25:33Z

OK! Just deployed this to staging if anyone wants to test.

So far, my tests are good! Basically, reporting an issue with a screenshot as an authed GitHub user works again. And it's soooo much faster thanks to @karlcow.

r? @karlcow

karlcow · 2016-05-20T02:08:42Z

This is working.

127.0.0.1 - - [20/May/2016 11:04:32] "POST /issues/new HTTP/1.1" 302 -
127.0.0.1 - - [20/May/2016 11:04:32] "GET /login HTTP/1.1" 302 -
127.0.0.1 - - [20/May/2016 11:04:42] "GET /callback?code=******* HTTP/1.1" 302 -
127.0.0.1 - - [20/May/2016 11:04:44] "GET /file HTTP/1.1" 302 -
127.0.0.1 - - [20/May/2016 11:04:44] "GET /thanks/397 HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /issues/397 HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /js/vendor/qr.min.js HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /js/lib/models/comment.js HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /js/lib/issues.js HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /js/lib/qrcode.js HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:22] "GET /js/lib/comments.js HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:24] "GET /api/issues/labels?per_page=100 HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:24] "GET /api/issues/397 HTTP/1.1" 200 -
127.0.0.1 - - [20/May/2016 11:05:24] "GET /uploads/2016/5/c701a0ad-0652-4325-b237-bf072a08b675.jpg HTTP/1.1" 200 -

webcompat/static/js/lib/bugform.js

+      // Note: this could fail in weird ways depending on how
+      // the user has edited the descField.
+      this.descField.val(function(idx, value) {
+        return value.replace(/!\[.+\.jpe*g\)$/, '');


karlcow · 2016-05-20T02:10:40Z

r+ @miketaylr

karlcow · 2016-05-20T02:11:43Z

Super extra with the two latest pull requests I have the feeling with suddenly bumped our UX ;) or at least unbroke it.

miketaylr · 2016-05-20T14:25:35Z

I have the feeling with suddenly bumped our UX ;) or at least unbroke it.

Little bit from Column A, little bit from Column B. :p

Mike Taylor added 8 commits May 19, 2016 16:50

Issue #1049. Accept only a base64 'image' in uploads.py

ffae0eb

Issue #1049. Remove image upload from issues/new route.

d25ec11

Issue #1049. Return jpg file extension for png uploads.

edaab81

(At the time this is called, Pillow doesn't know that we're going to convert the PNG to JPG just yet)

Issue #1049. Bump upload limit to 5.5MB to account for dataURI inflat…

bb59edd

…ion.

Issue #1049. Add new tiny loader for image uploads.

f466cad

Issue #1049. Add support for uploading image before form submission.

bf6260a

Issue #1049. Move image downsampling into own method.

8fdf4e5

Issue #1049. Downsample images selected from file input as well.

44d7df3

miketaylr added the status: in progress label May 19, 2016

Issue #1049. Update upload unit tests.

4cb71e3

karlcow reviewed May 20, 2016
View reviewed changes

karlcow merged commit da1e2a6 into master May 20, 2016

karlcow removed the status: in progress label May 20, 2016

miketaylr added status: add to changelog and removed status: add to changelog labels May 20, 2016

zoepage deleted the issues/1049/1 branch July 10, 2017 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1049. Upload images before form submission. #1053

Fixes #1049. Upload images before form submission. #1053

miketaylr commented May 19, 2016

miketaylr commented May 19, 2016

miketaylr commented May 19, 2016

karlcow commented May 20, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented May 20, 2016

karlcow commented May 20, 2016

miketaylr commented May 20, 2016

Fixes #1049. Upload images before form submission. #1053

Fixes #1049. Upload images before form submission. #1053

Conversation

miketaylr commented May 19, 2016

miketaylr commented May 19, 2016

miketaylr commented May 19, 2016

karlcow commented May 20, 2016

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

karlcow commented May 20, 2016

karlcow commented May 20, 2016

miketaylr commented May 20, 2016