Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1074 - Added clear filter event to LabelSearch method to trigg… #1078

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

deepthivenkat
Copy link
Member

…er URL change

r? @miketaylr

@miketaylr
Copy link
Member

miketaylr commented Jun 1, 2016

Yay! So the fix was pretty simple.

In the future, when you make a PR, can you explain the patch a little bit? That helps the reviewer to get up to speed quicker.

For this bug, something like "This patch triggers filter:clear in labelSearch (which ends up triggering filter:reset-stage which ends up calling updateModelParams (which calls updateURLParams -- which is what we want). It has the side effect of clearing filters in a search, which is a required constraint of our set up right now."

@deepthivenkat do you intend to write an intern test for this?

@miketaylr
Copy link
Member

@deepthivenkat do you intend to write an intern test for this?

Deepthi filed #1079 to track that.

@miketaylr
Copy link
Member

Also, thanks for the patch and bug fix! 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants