Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1280 - removed cursor pointer #1350

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fixes #1280 - removed cursor pointer #1350

merged 1 commit into from
Feb 21, 2017

Conversation

magsout
Copy link
Member

@magsout magsout commented Feb 18, 2017

Closed #1280

@magsout magsout requested a review from adamopenweb February 18, 2017 15:16
@zoepage zoepage changed the title Issues #1280 - removed cursor pointer Fixes #1280 - removed cursor pointer Feb 20, 2017
@zoepage
Copy link
Member

zoepage commented Feb 20, 2017

As #1280 was closed, I modified the title.
https://help.github.com/articles/closing-issues-via-commit-messages/

@magsout
Copy link
Member Author

magsout commented Feb 20, 2017

As #1280 was closed

???

@karlcow
Copy link
Member

karlcow commented Feb 20, 2017

@zoepage the issue #1280 is not closed. It will be closed by merging this pull request if it contains indeed the keyword Fixes, Fix, Resolves etc. Once @adamopenweb has reviewed the Pull request.

@zoepage
Copy link
Member

zoepage commented Feb 20, 2017

@magsout @karlcow weird. I was 100% sure it was closed this morning. 0_o

Anyway, changed the title so it contains a keyword.

@magsout
Copy link
Member Author

magsout commented Feb 20, 2017

@zoepage ah, the World "closed " in my commit message is enought to closed issue when it will be merged..

@zoepage
Copy link
Member

zoepage commented Feb 20, 2017

@magsout right.

As far as I understood before, there is a process that should be followed, right?
https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#submission-guidelines - Step 9. (Just to clarify for myself, b/c I am still trying not to make mistakes all the time.)

@karlcow
Copy link
Member

karlcow commented Feb 20, 2017

@magsout @zoepage is right and I have been strict with her on it too. We are trying to enforce a convention of writing for the messages. This should help us to avoid surprises.

@adamopenweb
Copy link
Collaborator

LGTM r+
Thanks @magsout! 😀

@adamopenweb adamopenweb merged commit 59e9c30 into master Feb 21, 2017
@adamopenweb adamopenweb deleted the issues/1280 branch February 21, 2017 21:15
Copy link
Collaborator

@adamopenweb adamopenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants