Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1491 - Fixed overflow SVG, causing a scroll on all the page #1511

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Fixes #1491 - Fixed overflow SVG, causing a scroll on all the page #1511

merged 3 commits into from
Apr 26, 2017

Conversation

magsout
Copy link
Member

@magsout magsout commented Apr 14, 2017

@magsout magsout requested a review from zoepage April 14, 2017 20:39
@zoepage
Copy link
Member

zoepage commented Apr 17, 2017

@magsout review needs to sit for another 2-3 days. really sorry :(
But saved it and will check ASAP!

@magsout
Copy link
Member Author

magsout commented Apr 18, 2017

@zoepage don't worry, take your time ❤️

zoepage
zoepage reviewed Apr 21, 2017
View reviewed changes
Copy link
Member

@zoepage zoepage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magsout The issue is fixed :)

The icons are closer together now as they were before, which makes them tricky to hit on mobile (as you can see below).

Before:
screen shot 2017-04-21 at 10 32 58 am

After:
screen shot 2017-04-21 at 10 33 07 am

It would be amazing, if we could fix this before merging? :)

@magsout
Copy link
Member Author

magsout commented Apr 26, 2017

@zoepage good catch 👍

@magsout
Copy link
Member Author

magsout commented Apr 26, 2017

@zoepage fixed, thanks for your review.

@zoepage zoepage merged commit de711fc into master Apr 26, 2017
@zoepage
Copy link
Member

zoepage commented Apr 26, 2017

LGTM! Thanks @magsout! :)

@zoepage zoepage deleted the issues/1491 branch April 26, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoepage zoepage zoepage left review comments

Assignees
No one assigned
Labels
lang: CSS status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magsout @zoepage @miketaylr