-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1643 - add colon and new line #1653
Conversation
tests/test_form.py
Outdated
@@ -113,8 +113,10 @@ def test_build_formdata(self): | |||
"""The data body sent to GitHup API.""" | |||
form_object = {'foo': 'bar'} | |||
actual = form.build_formdata(form_object) | |||
|
|||
print(actual) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
webcompat/form.py
Outdated
@@ -235,7 +236,7 @@ def build_formdata(form_object): | |||
**URL**: {url} | |||
**Problem type**: {problem_type} | |||
**Description**: {description} | |||
**Steps to Reproduce** {steps_reproduce} | |||
**Steps to Reproduce**: {steps_reproduce} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
f7e42f2
to
3dbd399
Compare
r? @miketaylr |
webcompat/form.py
Outdated
@@ -59,7 +59,7 @@ | |||
url_label = u'Site URL <span class="wc-Form-required">*</span>' | |||
browser_test_label = u'Did you test in another browser?' | |||
|
|||
steps_default = u"""For example, | |||
steps_default = u"""\nFor example, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
webcompat/form.py
Outdated
|
||
**Steps to Reproduce**: {steps_reproduce} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
720163d
to
e1d22e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! :)
We still want STR to be the last items in the report, with browser/version, os, tested another browser above it.
The reason being there may be a large screenshot and it's nicer if all the metadata is up top.
(see #1653 (comment))
(basically we want the result to be just like 1683384, with the |
FINAL_FINAL_FINAL_REALLY_FINAL_THIS_TIME_VERSION-2.py @miketaylr |
yessss |
No description provided.