Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1643 - add colon and new line #1653

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Fixes #1643 - add colon and new line #1653

merged 1 commit into from
Jul 18, 2017

Conversation

zoepage
Copy link
Member

@zoepage zoepage commented Jul 11, 2017

No description provided.

@zoepage zoepage requested review from miketaylr and cch5ng July 11, 2017 12:29
@@ -113,8 +113,10 @@ def test_build_formdata(self):
"""The data body sent to GitHup API."""
form_object = {'foo': 'bar'}
actual = form.build_formdata(form_object)

print(actual)

This comment was marked as abuse.

This comment was marked as abuse.

@@ -235,7 +236,7 @@ def build_formdata(form_object):
**URL**: {url}
**Problem type**: {problem_type}
**Description**: {description}
**Steps to Reproduce** {steps_reproduce}
**Steps to Reproduce**: {steps_reproduce}

This comment was marked as abuse.

@zoepage zoepage force-pushed the issues/1643/1 branch 2 times, most recently from f7e42f2 to 3dbd399 Compare July 11, 2017 23:25
@zoepage
Copy link
Member Author

zoepage commented Jul 11, 2017

r? @miketaylr

@@ -59,7 +59,7 @@
url_label = u'Site URL <span class="wc-Form-required">*</span>'
browser_test_label = u'Did you test in another browser?'

steps_default = u"""For example,
steps_default = u"""\nFor example,

This comment was marked as abuse.


**Steps to Reproduce**: {steps_reproduce}

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

@zoepage zoepage force-pushed the issues/1643/1 branch 3 times, most recently from 720163d to e1d22e3 Compare July 17, 2017 12:53
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! :)

We still want STR to be the last items in the report, with browser/version, os, tested another browser above it.

The reason being there may be a large screenshot and it's nicer if all the metadata is up top.

(see #1653 (comment))

@miketaylr
Copy link
Member

(basically we want the result to be just like 1683384, with the {steps_reproduce} bit on its own line.)

@zoepage
Copy link
Member Author

zoepage commented Jul 17, 2017

FINAL_FINAL_FINAL_REALLY_FINAL_THIS_TIME_VERSION-2.py @miketaylr

@miketaylr
Copy link
Member

FINAL_FINAL_FINAL_REALLY_FINAL_THIS_TIME_VERSION-2.py @miketaylr

yessss

@miketaylr miketaylr merged commit 2fa2211 into master Jul 18, 2017
@miketaylr miketaylr deleted the issues/1643/1 branch July 18, 2017 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants