Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1876 - Handles when data/milestones.json doesn't exist. #1878

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fixes #1876 - Handles when data/milestones.json doesn't exist. #1878

merged 1 commit into from
Nov 16, 2017

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Nov 16, 2017

r? @miketaylr Fixes the issue #1876.

It checks the file exists prior to try reading it and send an error message when it doesn't.

→ nosetests
...............................................................
----------------------------------------------------------------------
Ran 63 tests in 2.480s

OK

@karlcow karlcow requested a review from miketaylr November 16, 2017 02:31
@karlcow karlcow mentioned this pull request Nov 16, 2017
Closed
@miketaylr
Copy link
Member

Much nicer. Thanks!

@miketaylr miketaylr merged commit 0d8b423 into webcompat:master Nov 16, 2017
@karlcow karlcow deleted the 1876/1 branch March 30, 2018 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlcow @miketaylr