Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2774 - Fixes code blocks with language identifiers #2776

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

marimeireles
Copy link
Member

It's working for me:

screen shot 2019-01-24 at 19 41 32

r? @miketaylr

@marimeireles
Copy link
Member Author

Ahm... I'm not sure if

/* Code blocks */
pre[class *= "language-"],
.highlight > pre {
  background-color: var(--base-background);
  border: 1px solid #ddd;
  margin: .5em 0;
  overflow: auto;
  padding: 1em;
}

this is the right way of adding a new style. It doesn't match the rest of the code style. What do you think @magsout ? Is there anything I could do to make it better?

@miketaylr miketaylr requested a review from magsout January 24, 2019 22:44
@magsout
Copy link
Member

magsout commented Jan 27, 2019

@marimeireles

this is the right way of adding a new style. It doesn't match the rest of the code style. What do you think @magsout ? Is there anything I could do to make it better?

you can add this selector, there is no problem. It goes very well with the rest of the CSS

r+

@magsout magsout merged commit beb1eee into webcompat:master Jan 27, 2019
@marimeireles
Copy link
Member Author

Hi @karlcow
I think it's because this other PR wasn't accepted #2775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants