Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2086 - Creates an alumni contributor list #2853

Merged
merged 6 commits into from
Jun 1, 2020

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Apr 25, 2019

This PR fixes issue #2086

Proposed PR background

Trying to cater for people who contributed to the project in the past.

@karlcow
Copy link
Member Author

karlcow commented Apr 25, 2019

This is a first pass at creating an alumni page. There are missing people and probably bios to double check with each individual.

@tagawa
Copy link
Member

tagawa commented May 15, 2019

Looks like I'm listed twice in alumni.html. VIP treatment - achievement unlocked!!!

@karlcow
Copy link
Member Author

karlcow commented May 15, 2019

@tagawa ahah. Special guest ;) once for Opera, once for Mozilla :p

@karlcow karlcow marked this pull request as ready for review June 1, 2020 01:21
@karlcow karlcow requested a review from miketaylr June 1, 2020 01:22
@karlcow
Copy link
Member Author

karlcow commented Jun 1, 2020

Managed to finally finish this. Or I hope. 😝
Let's see.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

webcompat/templates/contributors/alumni.html Show resolved Hide resolved
webcompat/views.py Show resolved Hide resolved
@miketaylr miketaylr merged commit 1e2335d into webcompat:master Jun 1, 2020
@karlcow karlcow deleted the 2086/1 branch August 24, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants