Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2955 - Move the no-top-padding class to the codebase of the ex… #2960

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

munteanu210
Copy link
Contributor

@munteanu210 munteanu210 commented Oct 9, 2019

This PR fixes issue #2955 and @johngian feedback here: #2942 (comment)
The issue consisted of moving the 'no-top-padding' class to the codebase of the experiment.

To solve this issue, I removed the no-top-padding class from the shared HTML template and adjusted the styles contained in the experiment to achieve the same UI result.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@miketaylr miketaylr merged commit 2729de7 into webcompat:master Oct 9, 2019
@munteanu210 munteanu210 deleted the css-class-relocation branch October 10, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants