Fixes #2975 - "Briefly describe the issue" fix & validation #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
approved these changes
Oct 21, 2019
| @@ -24,6 +24,10 @@ function Validation() { | |||
| var val = descField.val(); | |||
| return $.trim(val) !== ""; | |||
| }, | |||
| isIssueValid: function(issueField) { | |||
There was a problem hiding this comment.
This seems like it's doing the same as isDescriptionValid -- in the future we might consider making them call the same method. But let's merge here to not block.
miketaylr
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2975
Proposed PR background
I added validation for the field. When this field is empty, the "Continue" button is disabled. When you enter something, the field is validated, the check symbol appears and the button is activated to proceed to the next step.