Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3297 - Adjust changelog for dependabot #3301

Closed
wants to merge 3 commits into from
Closed

Fixes #3297 - Adjust changelog for dependabot #3301

wants to merge 3 commits into from

Conversation

bijjybox
Copy link
Contributor

@bijjybox bijjybox commented May 10, 2020 •
edited
Loading

Fixes #3297

Modified changelog.py script to handle commit messages from @dependabot

@karlcow karlcow self-requested a review May 10, 2020 20:07
miketaylr
miketaylr reviewed May 11, 2020
View reviewed changes
tools/changelog.py Outdated Show resolved Hide resolved
karlcow
karlcow requested changes May 11, 2020
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little things to change.
Thanks for working on this. This is appreciated.

tests/unit/test_tools_changelog.py Outdated Show resolved Hide resolved
tests/unit/test_tools_changelog.py Outdated Show resolved Hide resolved
tools/changelog.py Outdated Show resolved Hide resolved
tools/changelog.py Outdated Show resolved Hide resolved
tools/changelog.py Outdated Show resolved Hide resolved
@karlcow karlcow changed the title Modified changelog.py Fixes #3297 - Adjust changelog for dependabot May 12, 2020
@karlcow
Copy link
Member

karlcow commented May 12, 2020

Thanks a lot @apsychogirl
I rebased a bit.

@karlcow
Copy link
Member

karlcow commented May 12, 2020

Closed by ad69300

@karlcow karlcow closed this May 12, 2020
@miketaylr
Copy link
Member

Awesome, thanks!

@karlcow karlcow mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr left review comments

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changelog.py script unable to handle commit messages from @dependabot
3 participants
@bijjybox @karlcow @miketaylr