Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2980 - Adding correct border for Invalid form #3306

Merged
merged 1 commit into from
May 25, 2020
Merged

Fixes #2980 - Adding correct border for Invalid form #3306

merged 1 commit into from
May 25, 2020

Conversation

soniasingla
Copy link
Contributor

Fixes #2980

@miketaylr
Copy link
Member

Cool! @soniasingla can you update your commit message to follow the PR guidelines?

https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md#add-commit-message-including-issue-number

(Also update the title as well: https://github.com/webcompat/webcompat.com/blob/master/docs/pr-coding-guidelines.md#send-a-pull-request)

@soniasingla soniasingla changed the title Adding correct border for Invalid form Fixes #2980 - Adding correct border for Invalid form May 13, 2020
@miketaylr miketaylr requested a review from ksy36 May 18, 2020 20:28
@miketaylr
Copy link
Member

(before we merge, we'll want to remove those 2 commits related to #3038, which I guess if we do a squash merge it will take care of...)

r? @ksy36

@soniasingla
Copy link
Contributor Author

@miketaylr , I removed those commits , ready for another look :)

ksy36
ksy36 approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@ksy36 ksy36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soniasingla :)

@ksy36 ksy36 merged commit 65f664c into webcompat:master May 25, 2020
@soniasingla soniasingla deleted the form-refactoring branch May 25, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksy36 ksy36 ksy36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New UI] Add correct border for invalid form element state
3 participants
@soniasingla @miketaylr @ksy36