Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3392 - Removes html and css for original form #3393

Closed
wants to merge 2 commits into from

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jul 15, 2020

This PR fixes issue #3392

Proposed PR background

We switch to the wizard form. This PR removes the HTML and CSS code related to the previous form

I hope I didn't miss anything.

@ksy36
Copy link
Contributor

ksy36 commented Jul 15, 2020

Just a drive by comment, the wizard styles actually depend on css in the form.css. I think also some other form elements across the site using it. So some of the code should stay.

I've started refactoring it, but got carried away by the fixes for IE11. So if you like, I can do the css part @karlcow

@miketaylr
Copy link
Member

I've started refactoring it, but got carried away by the fixes for IE11. So if you like, I can do the css part @karlcow

(It sounds like maybe we should not merge this PR yet)

@karlcow
Copy link
Member Author

karlcow commented Jul 15, 2020

Just a drive by comment, the wizard styles actually depend on css in the form.css. I think also some other form elements across the site using it. So some of the code should stay.

Ah cool! I tested yesterday and didn't see any failures, but I was not sure, it's why I was asking for review.

@karlcow
Copy link
Member Author

karlcow commented Jul 16, 2020

@ksy36

Forgotten to reply to this.

I've started refactoring it, but got carried away by the fixes for IE11. So if you like, I can do the css part @karlcow

YES no issue.

@ksy36
Copy link
Contributor

ksy36 commented Jul 27, 2020

@karlcow I've created a new PR #3416 with css refactoring

@karlcow
Copy link
Member Author

karlcow commented Jul 28, 2020

@ksy36 very cool.

@karlcow
Copy link
Member Author

karlcow commented Jul 28, 2020

ok so I guess we can now close this one.

@karlcow karlcow closed this Jul 28, 2020
@karlcow karlcow removed the request for review from magsout July 28, 2020 23:02
@karlcow karlcow deleted the 3392/1 branch August 24, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove HTML and CSS code associated with the old form
3 participants