Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3427 - Remove min char requirement from description field #3428

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jul 31, 2020

I've removed min char requirement, made the description optional and changed the copy:

Screen Shot 2020-07-31 at 6 08 25 PM

@ksy36 ksy36 requested a review from miketaylr July 31, 2020 23:07
@ksy36
Copy link
Contributor Author

ksy36 commented Jul 31, 2020

Also any feedback on the copy is appreciated :) We can change it to something else

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, let's merge and deploy this, but it would be nice to do A/B testing so we can compare apples to apples in the future. I guess we'll be able to compare this weeks data with last weeks data though to decide if we want this or not?

(Also, If you have a good reason for not using our AB testing stuff anymore, we should remove it)

@@ -230,32 +230,31 @@ <h3 class="page-heading">Filing a web compatibility issue</h3>
</div>
</div>

<div class="step-container step-description col">
<div class="step-container step-description col" data-min-char="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so we can toggle it on or off based on this.

I assumed we were going to do some A/B testing based on the existing AB test stuff we have, this approach would be compatible with that -- you set the value in the template based on active experiment.

@ksy36
Copy link
Contributor Author

ksy36 commented Aug 17, 2020

Thanks! Yeah, the plan is to compare previous two weeks with the week when this change was shipped. I was focusing on reducing drop off at this step, since the rate is pretty high. I think we can still use A/B testing for other steps, where the reason for drop off is not as clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants