Fixes #3456 - Add aria-labelled-by attributes to wizard step icons

[miketaylr]

In theory this should fix #3456, but the devtools accessbility inspector doesn't recognize the aria-labelled-by attribute, but I think that's a bug (I will file one and post a link here).

We can fix this error by duplicating the description text, but then a screen reader will read it twice, which seems bad.

[miketaylr]

https://bugzilla.mozilla.org/show_bug.cgi?id=1687198

[ksy36]

Thanks for looking into this! Not very familiar with this property, so I looked it up, looks like like it's aria-labelledby="" (without the hyphen), so may be devtools not recognizing it because of the hyphen

[miketaylr]

Thanks for looking into this! Not very familiar with this property, so I looked it up, looks like like it's aria-labelledby="" (without the hyphen), so may be devtools not recognizing it because of the hyphen

Oh yay, thanks for the careful review!

[miketaylr]

Nice, just confirmed it works :)

[miketaylr]

I guess we can do the same thing with the other icons, so let's not merge this just yet @ksy36 -- I can add that maybe later tonight.

[miketaylr]

Oh wait, those messages are about interactive semantics, etc. I don't plan on addressing those. We got all the image label issues taken care of.

r? @ksy36

[karlcow]

Thanks!

[ksy36]

Cool, thanks!

[miketaylr]

Thanks all!