Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3547 - Removes unused Requests library import #3549

Closed
wants to merge 1 commit into from

Conversation

NegiAkash890
Copy link
Contributor

This PR fixes issue #3547

Proposed PR background

This pull request removes redundant import from the file .

@ksy36 ksy36 requested a review from karlcow March 12, 2021 15:42
@karlcow karlcow changed the title Update - Removed Reduntant import from the file . Fix #3547. Removes unused import of requests library Mar 13, 2021
@karlcow karlcow linked an issue Mar 13, 2021 that may be closed by this pull request
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NegiAkash890 Thanks for the pull request.

Would you be able to reword the commit so it follows the convention of the project?

git rebase -i HEAD~2
# choose `r` for reword in front of the commit. 
# Change: 
#    Update - Removed Reduntant import from the file .
# By 
#    Issue #3547 - Removes unused Requests library import 
# then push again
git push -f origin master

If you can't I'll do it. Thanks a lot.

@NegiAkash890 NegiAkash890 changed the title Fix #3547. Removes unused import of requests library Issue #3547 - Removes unused Requests library import Mar 14, 2021
@karlcow karlcow changed the title Issue #3547 - Removes unused Requests library import Fix #3547 - Removes unused Requests library import Mar 17, 2021
@karlcow
Copy link
Member

karlcow commented Mar 23, 2021

I fixed the commit message manually. in 493ed7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove from requests.exceptions import HTTPError
3 participants