Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3574: Incorporate bugbug ml labelling into moderation process #3576

Merged
merged 1 commit into from
May 31, 2021
Merged

Fixes #3574: Incorporate bugbug ml labelling into moderation process #3576

merged 1 commit into from
May 31, 2021

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented May 27, 2021 •
edited
Loading

In this PR I've added functionality to automatically close issues marked by bugbug as invalid.

  1. Issues marked by bugbug as invalid moved to "ml-autoclosed" milestone.
  2. Once milestone event is received, public issue content is replaced with a placeholder text and label "bugbug-probability-high" is added, public issue closed.
  3. Private issue closed

Discussed in #3574

Example of a public test issue that was closed using this code: webcompat/webcompat-tests#2638

ksy36
ksy36 commented May 27, 2021
View reviewed changes
webcompat/webhooks/ml.py Outdated Show resolved Hide resolved
@ksy36 ksy36 requested a review from karlcow May 27, 2021 22:35
@ksy36
Copy link
Contributor Author

ksy36 commented May 27, 2021

r? @karlcow

karlcow
karlcow requested changes May 28, 2021
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksy36 This is really really really cool.

That will probably help a lot the softvision team. I made some comments and suggestions.

Only two points to think about:

  1. Milestones fetching vs hardcoded
  2. Logging success and failures of communicating with bugbug

config/environment.py Show resolved Hide resolved
config/environment.py Show resolved Hide resolved
tests/unit/test_webhook.py Outdated Show resolved Hide resolved
webcompat/issues.py Outdated Show resolved Hide resolved
webcompat/issues.py Outdated Show resolved Hide resolved
webcompat/webhooks/model.py Show resolved Hide resolved
webcompat/webhooks/model.py Show resolved Hide resolved
webcompat/webhooks/model.py Outdated Show resolved Hide resolved
webcompat/webhooks/model.py Outdated Show resolved Hide resolved
webcompat/webhooks/model.py Outdated Show resolved Hide resolved
@ksy36
Copy link
Contributor Author

ksy36 commented May 28, 2021

Ready for another look @karlcow :)

karlcow
karlcow approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ksy36
Awesome work.

config/environment.py Show resolved Hide resolved
config/environment.py Show resolved Hide resolved
@karlcow karlcow merged commit 81d7fd5 into master May 31, 2021
@karlcow karlcow deleted the issue/3574/1 branch May 31, 2021 00:50
@ksy36
Copy link
Contributor Author

ksy36 commented May 31, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksy36 @karlcow