Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3348 - Update contributing documentation #3601

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix #3348 - Update contributing documentation #3601

merged 1 commit into from
Jul 13, 2021

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jul 12, 2021

I've updated screenshots and text a bit :)

r? @karlcow

@ksy36 ksy36 requested a review from karlcow July 12, 2021 02:33
karlcow
karlcow requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksy36
That's wonderful.

Could you put the new images though ImageOptim? I just did for the first one, and I save 58%.

Capture d’écran 2021-07-12 à 15 25 58

Thanks!

@ksy36
Copy link
Contributor Author

ksy36 commented Jul 12, 2021

Updated the images, thanks for the tip @karlcow

karlcow
karlcow approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ksy36
That is a good update to the documentation.

@karlcow karlcow merged commit e56bd7c into main Jul 13, 2021
@karlcow karlcow linked an issue Jul 13, 2021 that may be closed by this pull request
Updating contributing documentation #3348
Closed
@karlcow karlcow changed the title Issue #3348 - Update contributing documentation Fix #3348 - Update contributing documentation Jul 13, 2021
@karlcow karlcow mentioned this pull request Jul 13, 2021
Closed
@ksy36 ksy36 deleted the issue/3348/1 branch July 13, 2021 14:56
@ksy36
Copy link
Contributor Author

ksy36 commented Jul 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating contributing documentation
2 participants
@ksy36 @karlcow