Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3685 - Automatically add labels for issues reopened after ML triage #3686

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Apr 1, 2022

This will help with analytics to determine the false-positive rate of the model using our Elastic search data: how many issues ML bot closed per week/ how many were reopened / how many of those ended up being "valid" ( i.e. milestoned to needsdiagnosis/moved).

  • bugbug-reopened label for issues that have been reopened after ML bot closed them;
  • bugbug-valid to issues that have bugbug-reopened label AND has been moved to needsdiagnosis or moved milestone;

@ksy36
Copy link
Contributor Author

ksy36 commented Apr 2, 2022

The build tests are failing with these errors:

  if request is None:
>           builder = EnvironBuilder(*args, **kwargs)
E           TypeError: __init__() got an unexpected keyword argument 'as_tuple'

env/lib/python3.9/site-packages/werkzeug/test.py:1081: TypeError

This is probably because of the change in werkzeug:
https://stackoverflow.com/questions/71661851/typeerror-init-got-an-unexpected-keyword-argument-as-tuple

https://flask.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
The test client’s as_tuple parameter is removed. Use response.request.environ instead.

I'll address this in a separate PR.

@ksy36 ksy36 marked this pull request as draft April 2, 2022 01:32
@ksy36 ksy36 marked this pull request as ready for review April 5, 2022 20:37
@ksy36
Copy link
Contributor Author

ksy36 commented Apr 5, 2022

r? @karlcow

@ksy36 ksy36 requested a review from karlcow April 5, 2022 20:42
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ksy36

@karlcow karlcow merged commit 301e687 into main Apr 6, 2022
@karlcow karlcow deleted the issue/3685/1 branch April 6, 2022 02:16
@ksy36
Copy link
Contributor Author

ksy36 commented Apr 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants