533/1 Refactoring and adding needscontact #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good here. I'm going to land #531 first, then I'll fix any merge conflicts that creates for you. (Note, tests are failing because fork PRs can't have access to secure environment variables, which we use to hold... secret stuff!) |
|
@karlcow all merged, tests passing. I just had to rename 🍸 |
magsout
added a commit
that referenced
this pull request
Mar 8, 2015
magsout
added a commit
that referenced
this pull request
Mar 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a bit the code around categories and add the needscontact keyword as one of the option.
r? @miketaylr