Adding labels tests fix #272 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
pushed a commit
that referenced
this pull request
Aug 14, 2015
Adding labels tests fix #272
|
So it turns out in reporting.js we log out--so these tests all failed. I did a quick "log in" in the first test @ 535ba46, just as a temporary measure until we use the setup/teardown stuff for all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the setup and teardown are not yet written, but ready to fill, once I figured out how to properly do it. And maybe it's something more general.
The PR can be merged once reviewed.
Right now the tests will execute in the flow, with the assumption that the login has already happened.
@miketaylr r?