-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New label code - fixes #783, #784, #797, #799 #796
Conversation
the full list from GitHub, #783
… some obsolete prefix handling
* new issues.LabelList({url:'/path/to/labels.json'}); | ||
*/ | ||
|
||
issues.LabelList = Backbone.Model.extend({ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Looks good to me, just a few things to fix:
|
(On the /api/labels requests, we're probably moving towards having a set of labels "hard-coded" in config, if we can land that soon we won't be using GitHub API here at all I think. But I'll figure out how to make it a "proxy call" meanwhile.) |
Take a look at the |
Ready to merge! |
I'm waiting to see if GitHub is smart enough to auto-close all four issues mentioned in summary when @miketaylr merges this :) |
Awesome, thanks @hallvors. |
r?@miketaylr