Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New label code - fixes #783, #784, #797, #799 #796

Merged
merged 16 commits into from
Oct 26, 2015
Merged

New label code - fixes #783, #784, #797, #799 #796

merged 16 commits into from
Oct 26, 2015

Conversation

hallvors
Copy link
Contributor

@miketaylr
Copy link
Member

* new issues.LabelList({url:'/path/to/labels.json'});
*/

issues.LabelList = Backbone.Model.extend({

This comment was marked as abuse.

@miketaylr
Copy link
Member

Looks good to me, just a few things to fix:

  • move label model to own file
  • update failing test
  • teach @api.route('/issues/labels') how to do a proxy request for non-auth users

@hallvors
Copy link
Contributor Author

(On the /api/labels requests, we're probably moving towards having a set of labels "hard-coded" in config, if we can land that soon we won't be using GitHub API here at all I think. But I'll figure out how to make it a "proxy call" meanwhile.)

@miketaylr
Copy link
Member

Take a look at the /rate_limit endpoint, that's a pretty simple example of how to do it.

@hallvors
Copy link
Contributor Author

Ready to merge!

@hallvors hallvors changed the title New label code - fixes #783, #784 New label code - fixes #783, #784, #797 Oct 24, 2015
@hallvors
Copy link
Contributor Author

I'm waiting to see if GitHub is smart enough to auto-close all four issues mentioned in summary when @miketaylr merges this :)

@hallvors hallvors changed the title New label code - fixes #783, #784, #797 New label code - fixes #783, #784, #797, #799 Oct 26, 2015
@miketaylr
Copy link
Member

Awesome, thanks @hallvors.

miketaylr pushed a commit that referenced this pull request Oct 26, 2015
@miketaylr miketaylr merged commit d6b97ea into master Oct 26, 2015
@miketaylr miketaylr deleted the labelworks branch March 5, 2016 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants