Fixes #860. Enable pep8 for Travis (and make eslint task do what we want for JS)

.eslintrc

@@ -14,12 +14,14 @@
     markdownitEmoji: true,
     markdownitSanitizer: true,
     md: true,
+    module: true,
     moment: true,
     Mousetrap: true,
     PaginationMixin: true,
     Prism: true,
     qr: true,
     repoPath: true,
+    require: true,
     wcEvents: true
   },
   "rules": {

.travis.yml

@@ -34,10 +34,13 @@ install:
   - travis_retry npm install
   - travis_retry pip install -r requirements.txt --download-cache $HOME/.pip-cache
   - cp config.py.example config.py
+  # lint python
+  - pep8 --ignore=E402 webcompat/ tests/ config.py.example
   - python run.py -t &
 
 before_script:
   - "sleep 2"
+  # lint JS in default eslint task
   - grunt
 
 # now run the tests!

Gruntfile.js

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-module.exports = function (grunt) {
+module.exports = function(grunt) {
   grunt.initConfig({
     pkg: grunt.file.readJSON('package.json'),
     jsPath: 'webcompat/static/js',
@@ -19,7 +19,7 @@ module.exports = function (grunt) {
   grunt.loadTasks('grunt-tasks');
 
   // load all grunt tasks
-  require('load-grunt-tasks')(grunt)
+  require('load-grunt-tasks')(grunt);
 
   // Default task.
   grunt.registerTask('default', [

config.py.example

@@ -64,8 +64,8 @@ if not PRODUCTION:
 LOG_FILE = '/tmp/webcompat.log'
 LOG_FMT = '%(asctime)s %(levelname)s: %(message)s [in %(pathname)s:%(lineno)d]'
 
-# Get the client id and client secret from GitHub if you're part of the webcompat
-# organization. Otherwise, create your own test and production applications,
+# Get the client id and client secret from GitHub if you're part of the
+# webcompat org. Otherwise, create your own test and production applications,
 # and take note of the client id and client secret GitHub gives you.
 #
 # [1]<https://github.com/organizations/webcompat/settings/applications/>
@@ -84,7 +84,7 @@ elif DEVELOPMENT:
 else:
     # We're running on localhost, use the test application
     GITHUB_CLIENT_ID = os.environ.get('FAKE_ID') or ""
-    GITHUB_CLIENT_SECRET = os.environ.get('FAKE_SECRET') or  ""
+    GITHUB_CLIENT_SECRET = os.environ.get('FAKE_SECRET') or ""
     GITHUB_CALLBACK_URL = "http://localhost:5000/callback"
 
 # GiHub Issues repo URI
@@ -93,7 +93,7 @@ if PRODUCTION:
 else:
     # Development and Local instances use the same test repo
     # Expects a string like "<user>/<repo>/issues", e.g.,
-    # ISSUES_REPO_URI = os.environ.get('ISSUES_REPO_URI') or "miketaylr/test-repo/issues"
+    # ISSUES_REPO_URI = os.environ.get('ISSUES_REPO_URI') or "foo/bar/issues"
     ISSUES_REPO_URI = os.environ.get('ISSUES_REPO_URI') or ""
 
 # This is the oauth token we use to report issues on behalf of people

grunt-tasks/cmq.js

@@ -4,13 +4,13 @@
 
 module.exports = function(grunt) {
   grunt.config('cmq', {
-      options: {
-        log: true
-      },
-      your_target: {
-        files: {
-          '<%= cssPath %>' : ['<%= cssPath %>/webcompat.dev.css']
-        }
+    options: {
+      log: true
+    },
+    your_target: {
+      files: {
+        '<%= cssPath %>' : ['<%= cssPath %>/webcompat.dev.css']
       }
-   });
+    }
+  });
 };

grunt-tasks/concat.js

@@ -4,76 +4,76 @@
 
 module.exports = function(grunt) {
   grunt.config('concat', {
-      options: {
-        banner: '<%= banner %>',
-        stripBanners: false
-      },
-      dist: {
-        src: [
-            '<%= jsPath %>/vendor/jquery-1.11.2.min.js',
-            '<%= jsPath %>/vendor/lodash.custom.min.js',
-            '<%= jsPath %>/vendor/backbone-min.js',
-            '<%= jsPath %>/vendor/moment-min.js',
-            '<%= jsPath %>/vendor/prism.js',
-            '<%= jsPath %>/vendor/markdown-it.js',
-            '<%= jsPath %>/vendor/markdown-it-emoji-1.0.0.js',
-            '<%= jsPath %>/vendor/markdown-it-sanitizer-0.4.1.js',
-            '<%= jsPath %>/vendor/mousetrap-min.js',
-            '<%= jsPath %>/vendor/backbone.mousetrap.js',
-            '<%= jsPath %>/lib/flash-message.js',
-            '<%= jsPath %>/lib/homepage.js',
-            '<%= jsPath %>/lib/bugform.js'
-        ],
-        dest: '<%= jsPath %>/<%= pkg.name %>.js'
-      },
-      diagnose: {
-        src: [
-            '<%= jsPath %>/lib/models/label-list.js',
-            '<%= jsPath %>/lib/labels.js',
-            '<%= jsPath %>/lib/models/issue.js',
-            '<%= jsPath %>/lib/diagnose.js'
-        ],
-        dest: '<%= jsPath %>/diagnose.js'
-      },
-      issues: {
-        src: [
-            '<%= jsPath %>/vendor/qr.min.js',
-            '<%= jsPath %>/lib/models/label-list.js',
-            '<%= jsPath %>/lib/labels.js',
-            '<%= jsPath %>/lib/models/issue.js',
-            '<%= jsPath %>/lib/models/comment.js',
-            '<%= jsPath %>/lib/comments.js',
-            '<%= jsPath %>/lib/qrcode.js',
-            '<%= jsPath %>/lib/issues.js',
-        ],
-        dest: '<%= jsPath %>/issues.js'
-      },
-      issueList: {
-        src: [
-          '<%= jsPath %>/lib/models/label-list.js',
-          '<%= jsPath %>/lib/labels.js',
-          '<%= jsPath %>/lib/models/issue.js',
-          '<%= jsPath %>/lib/mixins/pagination.js',
-          '<%= jsPath %>/lib/issue-list.js'
-        ],
-        dest: '<%= jsPath %>/issue-list.js'
-      },
-      userActivity: {
-        src: [
-          '<%= jsPath %>/lib/models/label-list.js',
-          '<%= jsPath %>/lib/models/issue.js',
-          '<%= jsPath %>/lib/mixins/pagination.js',
-          '<%= jsPath %>/lib/user-activity.js'
-        ],
-        dest: '<%= jsPath %>/user-activity.js'
-      },
-      cssFixmeLibs: {
-        src: [
-          'git_modules/css-fixme/js/css-browserside.js',
-          'git_modules/css-fixme/js/css-fixme.js',
-          '<%= jsPath %>/lib/css-fixme-ui.js'
-        ],
-        dest: '<%= jsPath %>/cssfixme/cssfixme.js'
-      }
-   });
+    options: {
+      banner: '<%= banner %>',
+      stripBanners: false
+    },
+    dist: {
+      src: [
+        '<%= jsPath %>/vendor/jquery-1.11.2.min.js',
+        '<%= jsPath %>/vendor/lodash.custom.min.js',
+        '<%= jsPath %>/vendor/backbone-min.js',
+        '<%= jsPath %>/vendor/moment-min.js',
+        '<%= jsPath %>/vendor/prism.js',
+        '<%= jsPath %>/vendor/markdown-it.js',
+        '<%= jsPath %>/vendor/markdown-it-emoji-1.0.0.js',
+        '<%= jsPath %>/vendor/markdown-it-sanitizer-0.4.1.js',
+        '<%= jsPath %>/vendor/mousetrap-min.js',
+        '<%= jsPath %>/vendor/backbone.mousetrap.js',
+        '<%= jsPath %>/lib/flash-message.js',
+        '<%= jsPath %>/lib/homepage.js',
+        '<%= jsPath %>/lib/bugform.js'
+      ],
+      dest: '<%= jsPath %>/<%= pkg.name %>.js'
+    },
+    diagnose: {
+      src: [
+        '<%= jsPath %>/lib/models/label-list.js',
+        '<%= jsPath %>/lib/labels.js',
+        '<%= jsPath %>/lib/models/issue.js',
+        '<%= jsPath %>/lib/diagnose.js'
+      ],
+      dest: '<%= jsPath %>/diagnose.js'
+    },
+    issues: {
+      src: [
+        '<%= jsPath %>/vendor/qr.min.js',
+        '<%= jsPath %>/lib/models/label-list.js',
+        '<%= jsPath %>/lib/labels.js',
+        '<%= jsPath %>/lib/models/issue.js',
+        '<%= jsPath %>/lib/models/comment.js',
+        '<%= jsPath %>/lib/comments.js',
+        '<%= jsPath %>/lib/qrcode.js',
+        '<%= jsPath %>/lib/issues.js',
+      ],
+      dest: '<%= jsPath %>/issues.js'
+    },
+    issueList: {
+      src: [
+        '<%= jsPath %>/lib/models/label-list.js',
+        '<%= jsPath %>/lib/labels.js',
+        '<%= jsPath %>/lib/models/issue.js',
+        '<%= jsPath %>/lib/mixins/pagination.js',
+        '<%= jsPath %>/lib/issue-list.js'
+      ],
+      dest: '<%= jsPath %>/issue-list.js'
+    },
+    userActivity: {
+      src: [
+        '<%= jsPath %>/lib/models/label-list.js',
+        '<%= jsPath %>/lib/models/issue.js',
+        '<%= jsPath %>/lib/mixins/pagination.js',
+        '<%= jsPath %>/lib/user-activity.js'
+      ],
+      dest: '<%= jsPath %>/user-activity.js'
+    },
+    cssFixmeLibs: {
+      src: [
+        'git_modules/css-fixme/js/css-browserside.js',
+        'git_modules/css-fixme/js/css-fixme.js',
+        '<%= jsPath %>/lib/css-fixme-ui.js'
+      ],
+      dest: '<%= jsPath %>/cssfixme/cssfixme.js'
+    }
+  });
 };

grunt-tasks/cssmin.js

@@ -4,17 +4,17 @@
 
 module.exports = function(grunt) {
   grunt.config('cssmin', {
-      options: {
-        banner: '<%= banner %>'
-      },
-      combine: {
-        files: {
-          // output
-          '<%= cssPath %>/webcompat.min.css': [
-            // input
-            '<%= cssPath %>/webcompat.dev.css'
-          ]
-        }
+    options: {
+      banner: '<%= banner %>'
+    },
+    combine: {
+      files: {
+        // output
+        '<%= cssPath %>/webcompat.min.css': [
+          // input
+          '<%= cssPath %>/webcompat.dev.css'
+        ]
       }
-   });
+    }
+  });
 };

grunt-tasks/cssnext.js

@@ -8,12 +8,12 @@ module.exports = function(grunt) {
       sourcemap: true,
       url : false,
       browsers: ['ff >= 4', 'ie >= 8', 'safari >= 5.1', 'opera >= 12', 'chrome >=10'],
-      import: { path: ["node_modules"] }
+      import: { path: ['node_modules'] }
     },
-      dist: {
-        files: {
-          '<%= cssPath %>/webcompat.dev.css': '<%= cssPath %>/development/main.css'
-        }
+    dist: {
+      files: {
+        '<%= cssPath %>/webcompat.dev.css': '<%= cssPath %>/development/main.css'
       }
-   });
+    }
+  });
 };

grunt-tasks/eslint.js

@@ -4,9 +4,12 @@
 
 module.exports = function(grunt) {
   grunt.config('eslint', {
-      target: [
-        '<%= jsPath %>/lib/*.js',
-        'tests/functional/*.js'
-      ]
-   });
+    target: [
+      '<%= jsPath %>/lib/*.js',
+      '<%= jsPath %>/lib/mixins/*.js',
+      '<%= jsPath %>/lib/models/*.js',
+      'grunt-tasks/*.js',
+      'tests/functional/*.js'
+    ]
+  });
 };

grunt-tasks/imagemin.js

@@ -24,7 +24,7 @@ module.exports = function(grunt) {
         cwd:    '<%= imgPath %>/',
         src:    ['*.jpg'],
         dest:   '<%= imgPath %>/'
-        }]
-      }
+      }]
+    }
   });
 };

grunt-tasks/uglify.js

@@ -4,33 +4,33 @@
 
 module.exports = function(grunt) {
   grunt.config('uglify', {
-      options: {
-        banner: '<%= banner %>',
-        mangle: false
-      },
-      dist: {
-        src: '<%= concat.dist.dest %>',
-        dest: '<%= jsPath %>/<%= pkg.name %>.min.js'
-      },
-      issues: {
-        src: '<%= concat.issues.dest %>',
-        dest: '<%= jsPath %>/issues.min.js'
-      },
-      issueList: {
-        src: '<%= concat.issueList.dest %>',
-        dest: '<%= jsPath %>/issue-list.min.js'
-      },
-      userActivity: {
-        src: '<%= concat.userActivity.dest %>',
-        dest: '<%= jsPath %>/user-activity.min.js'
-      },
-      diagnose: {
-        src: '<%= concat.diagnose.dest %>',
-        dest: '<%= jsPath %>/diagnose.min.js'
-      },
-      cssFixmeLibs: {
-        src: '<%= concat.cssFixmeLibs.dest %>',
-        dest: '<%= jsPath %>/cssfixme.min.js'
-      }
-   });
+    options: {
+      banner: '<%= banner %>',
+      mangle: false
+    },
+    dist: {
+      src: '<%= concat.dist.dest %>',
+      dest: '<%= jsPath %>/<%= pkg.name %>.min.js'
+    },
+    issues: {
+      src: '<%= concat.issues.dest %>',
+      dest: '<%= jsPath %>/issues.min.js'
+    },
+    issueList: {
+      src: '<%= concat.issueList.dest %>',
+      dest: '<%= jsPath %>/issue-list.min.js'
+    },
+    userActivity: {
+      src: '<%= concat.userActivity.dest %>',
+      dest: '<%= jsPath %>/user-activity.min.js'
+    },
+    diagnose: {
+      src: '<%= concat.diagnose.dest %>',
+      dest: '<%= jsPath %>/diagnose.min.js'
+    },
+    cssFixmeLibs: {
+      src: '<%= concat.cssFixmeLibs.dest %>',
+      dest: '<%= jsPath %>/cssfixme.min.js'
+    }
+  });
 };