-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #929 - Generic error handler based on status code for status 40… #949
Conversation
r? @karlcow (I can review too, but Karl suggested this approach -- would be interested in his feedback). |
@deepthivenkat can you run pep8 and fix up any lint errors there?
|
Sure..checking
|
Conflicts: webcompat/views.py
@deepthivenkat Thanks for starting working on this. Let's discuss a bit more. ^_^ So in my approach I realized that I mixed two ways of making it more DRY, and it's probably over-doing it.
We still need a dictionary for error messages. We also need to figure out if we want to have separate messaging for HTML (Human calls) and JSON (API calls). Opinions? If what I say above is not clear enough, I can go a bit more in details. :) |
I accidentally deleted requirements.txt. there were few more issues. So I deleted the repository and cloned it again and started with a clean branch(the one I submitted yesterday is from this new branch). Is it okay if we continue with the new pull request? |
@deepthivenkat so let's closed this issue in favor of #958, sounds good ? |
Yes..Thanks :) |
…0,401,403,404