Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #900 - postcss-cssnext #960

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Issue #900 - postcss-cssnext #960

merged 1 commit into from
Mar 23, 2016

Conversation

magsout
Copy link
Member

@magsout magsout commented Mar 11, 2016

grunt-cssnext is depreacted, so I added postcss-cssnext

Instrcutions:

npm uninstall grunt-cssnext
npm install
make build

r? @miketaylr

Close #900

@magsout magsout changed the title Postcss cssnext Issue #900 - postcss-cssnext Mar 11, 2016
@miketaylr
Copy link
Member

LGTM (everything works as expected locally)

@miketaylr
Copy link
Member

(we might have to clear the Travis cache if the tests fail post-merge)

@miketaylr miketaylr merged commit 6222142 into master Mar 23, 2016
@miketaylr miketaylr deleted the postcss-cssnext branch March 23, 2016 17:36
@magsout
Copy link
Member Author

magsout commented Mar 23, 2016

poke @webcompat/collaborators

npm uninstall grunt-cssnext
npm install
make build

cc @webcompat/collaborators @dstreet @StabbyMcDuck @tsah20 @deepthivenkat @cch5ng @dshgna

@miketaylr
Copy link
Member

In theory our checkDependencies grunt task should catch this -- something like:

🐓 grunt
Loading "cssnext.js" tasks...ERROR
>> Error: Cannot find module 'postcss-cssnext'

Running "checkDependencies:default" (checkDependencies) task
>> postcss-cssnext: not installed!
>> Invoke npm install to install missing packages
Warning: Task "checkDependencies:default" failed. Use --force to continue.

But not a bad idea to remove grunt-cssnext

@magsout
Copy link
Member Author

magsout commented Mar 23, 2016

Ah yes good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants