-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
Note: Before this merges, I need to do a quick sanity check in a few consuming projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. To play it safe, do a beta so we get some initial feedback. Then go stable if nothing appears. 👍
@bebraw - Last line in the initial pull request comment :) |
Ah, ok. Netcraft confirms it. 👍 |
This bricks |
Hello @d3viant0ne Is there anything I can pick up here to help getting the PR finalised? |
Not at the moment. There was a hold on the defaults upgrades while we figured out the best way to setup the Jest suites to execute tests through webpack without sacrificing Jest features |
Sure, I'll remain close, in case there is even a dot I can write to help with :) |
@filipesilva - Friendly heads up, there is a It applies I'll push it out on a beta dist-tag and run it through it's paces. Once we are satisfied with it, i'll ping you again incase you want to run it in dev before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an update with latest webpack-defaults
:D, still using yarn
&& old npm scripts
@d3viant0ne thanks for the heads up! I can test the new version in Angular CLI once there's a npm tag up that I can use. |
@michael-ciniawsky - Yeah, holding off on this until we decide on the npm changes & push those out in defaults. |
What kind of change does this PR introduce? (check one with "x")
loader-utils
to version1.1.0
object-assign
pollyfillBabel
configurationEslint
configurationcommonjs
proxy for"main": "dist/cjs.js"
to account for ES module.default
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
As a part of the
webpack-defaults
upgrade a NodeJS version of 4.3 or newer is enforced."engines": { "node": ">= 4.3 < 5.0.0 || >= 5.10" }
,The loader-utils package has also been updated to
^1.1.0
which also requiresNodeJS > 4.3
Other information:
Merge & release as a
semver: MAJOR
with the properbreaking change
notations in the squash commits footer.Publish as
3.0.0
on thebeta dist-tag
Closes #53