Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

refactor: upgrade to webpack-defaults #51

Merged
merged 9 commits into from
Jun 8, 2017

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Mar 22, 2017

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:
  • Updates loader-utils to version 1.1.0
  • Drops object-assign pollyfill
  • Adds contrib standard Babel configuration
  • Adds contrib standard Eslint configuration
  • Refactors to utilize ES6+ JavaScript features
  • Adds a commonjs proxy for "main": "dist/cjs.js" to account for ES module .default

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

  • As a part of the webpack-defaults upgrade a NodeJS version of 4.3 or newer is enforced.
    "engines": { "node": ">= 4.3 < 5.0.0 || >= 5.10" },

  • The loader-utils package has also been updated to ^1.1.0 which also requires NodeJS > 4.3

Other information:

Merge & release as a semver: MAJOR with the proper breaking change notations in the squash commits footer.

Publish as 3.0.0 on the beta dist-tag

Closes #53

@joshwiens joshwiens self-assigned this Mar 22, 2017
@joshwiens joshwiens requested review from bebraw and deepsweet March 22, 2017 14:41
@joshwiens
Copy link
Member Author

Note: Before this merges, I need to do a quick sanity check in a few consuming projects.

Copy link

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. To play it safe, do a beta so we get some initial feedback. Then go stable if nothing appears. 👍

@joshwiens
Copy link
Member Author

@bebraw - Last line in the initial pull request comment :)

@bebraw
Copy link

bebraw commented Mar 22, 2017

Ah, ok. Netcraft confirms it. 👍

@joshwiens
Copy link
Member Author

joshwiens commented Mar 22, 2017

This bricks @angular/cli in it's current state and will require an upgrade path and/or a pull request to the cli as a part of this going from beta to latest on the dist-tag.

@DanielaValero
Copy link

Hello @d3viant0ne

Is there anything I can pick up here to help getting the PR finalised?

@joshwiens
Copy link
Member Author

Not at the moment. There was a hold on the defaults upgrades while we figured out the best way to setup the Jest suites to execute tests through webpack without sacrificing Jest features

@DanielaValero
Copy link

Sure, I'll remain close, in case there is even a dot I can write to help with :)

@joshwiens
Copy link
Member Author

@filipesilva - Friendly heads up, there is a semver Major coming for istanbul-instrumenter-loader. No changes in functionality or the loaders API.

It applies webpack-defaults which in turn enforces the standard webpack versions for engines with the bottom limit being NodeJS 4.3. So Major for the loader, no change for @angular/cli.

I'll push it out on a beta dist-tag and run it through it's paces. Once we are satisfied with it, i'll ping you again incase you want to run it in dev before 3.0.0 goes to @latest

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an update with latest webpack-defaults :D, still using yarn && old npm scripts

@filipesilva
Copy link
Contributor

@d3viant0ne thanks for the heads up! I can test the new version in Angular CLI once there's a npm tag up that I can use.

@joshwiens
Copy link
Member Author

@michael-ciniawsky - Yeah, holding off on this until we decide on the npm changes & push those out in defaults.

@joshwiens joshwiens merged commit b46a5c8 into master Jun 8, 2017
@joshwiens joshwiens deleted the d3viant0ne-DefaultsUpgrade branch June 8, 2017 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack-defaults upgrade
6 participants