feat: add options validation (schema-utils)

[michael-ciniawsky]

Blocked by #63

[mattlewis92]

Good idea! This is semver major btw as the loader will throw on invalid options now: https://github.com/webpack-contrib/schema-utils/blob/master/src/validateOptions.js#L20

[mattlewis92]

What about sourceMapUrlCallback?

[michael-ciniawsky]

You're right but luckily v3.0.0 is in beta atm 😅

What about sourceMapUrlCallback?

It's a {Function} which isn't directly supported by ajv (JSON Schema) and I hadn't the time to look into a custom extension to support this type in schema-utils yet, but it is highly needed :). additionalProperties: true is the workaround meanwhile 😛

[mattlewis92]

Fair enough 🙂

[mattlewis92]

@michael-ciniawsky can you rebase this on master? 😄 Also might be worth adding a test that it throws on an invalid option type.

[codecov]

Codecov Report

Merging #65 into master will increase coverage by 1.39%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #65      +/-   ##
=========================================
+ Coverage    90.9%   92.3%   +1.39%     
=========================================
  Files           2       2              
  Lines          11      13       +2     
  Branches        2       2              
=========================================
+ Hits           10      12       +2     
  Misses          1       1

Impacted Files	Coverage Δ
src/index.js	91.66% <100%> (+1.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4525107...e516db6. Read the comment docs.

[codecov]

Codecov Report

Merging #65 into master will increase coverage by 1.39%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #65      +/-   ##
=========================================
+ Coverage    90.9%   92.3%   +1.39%     
=========================================
  Files           2       2              
  Lines          11      13       +2     
  Branches        2       2              
=========================================
+ Hits           10      12       +2     
  Misses          1       1

Impacted Files	Coverage Δ
src/index.js	91.66% <100%> (+1.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4525107...678a8d0. Read the comment docs.

[mattlewis92]

LGTM