Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Useable section code in README.md #350

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fixed Useable section code in README.md #350

merged 1 commit into from
Mar 21, 2019

Conversation

marcogrcr
Copy link
Contributor

@marcogrcr marcogrcr commented Nov 8, 2018

The code example does not include a exclude entry, which causes the loaders to load twice on ".useable.css" files and failing the build.

The code example does not include a `exclude` entry, which causes the loaders to load twice on ".useable.css" files and failing the build.
@jsf-clabot
Copy link

jsf-clabot commented Nov 8, 2018

CLA assistant check
All committers have signed the CLA.

@marcogrcr
Copy link
Contributor Author

An example of the type of issues encountered can be seen here.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #350   +/-   ##
======================================
  Coverage    97.1%   97.1%           
======================================
  Files           4       4           
  Lines          69      69           
  Branches       23      23           
======================================
  Hits           67      67           
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8003966...9a313ab. Read the comment docs.

@alexander-akait
Copy link
Member

Please accept CLA

@hiroppy
Copy link
Contributor

hiroppy commented Mar 21, 2019

@evilebottnawi This pr can merge 👍

@alexander-akait alexander-akait merged commit d6c4959 into webpack-contrib:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants