refactor: pull out errorMessage constant

webpack-contrib · Jan 17, 2017 · d0635bb · d0635bb
1 parent 4e47a5e
commit d0635bb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/constants.js b/lib/constants.js
@@ -1,5 +1,6 @@
 'use strict';
 
 module.exports = {
-  defaultFilesGlob: '**/*.s?(c|a)ss'
+  defaultFilesGlob: '**/*.s?(c|a)ss',
+  errorMessage: 'Failed because of a stylelint error.\n'
 };
diff --git a/lib/run-compilation.js b/lib/run-compilation.js
@@ -2,6 +2,7 @@
 
 var chalk = require('chalk');
 var linter = require('./linter');
+var errorMessage = require('./constants').errorMessage;
 
 /**
  * Function bound to the plugin `apply` method to run the linter and report any
@@ -31,14 +32,14 @@ module.exports = function runCompilation (options, compiler, done) {
       }
 
       if (options.failOnError && errors.length) {
-        done(new Error('Failed because of a stylelint error.\n'));
+        done(new Error(errorMessage));
       } else {
         done();
       }
     })
     .catch(done);
 
-  compiler.plugin('after-emit', function onCompilation (compilation, callback) {
+  compiler.plugin('after-emit', function afterEmit (compilation, callback) {
     if (warnings.length) {
       compilation.warnings.push(chalk.yellow(options.formatter(warnings)));
       warnings = [];

diff --git a/test/index.test.js b/test/index.test.js
@@ -8,6 +8,7 @@ var webpack = require('./helpers/webpack');
 var baseConfig = require('./helpers/base-config');
 
 var configFilePath = getPath('./.stylelintrc');
+var errorMessage = require('../lib/constants').errorMessage;
 
 describe('stylelint-webpack-plugin', function () {
   it('works with a simple file', function () {
@@ -52,7 +53,7 @@ describe('stylelint-webpack-plugin', function () {
     return pack(assign({}, baseConfig, config))
       .then(expect.fail)
       .catch(function (err) {
-        expect(err.message).to.equal('Failed because of a stylelint error.\n');
+        expect(err.message).to.equal(errorMessage);
       });
   });