Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: warnings rather than errors #65

Closed
Vinnl opened this issue Jan 30, 2017 · 5 comments
Closed

Feature request: warnings rather than errors #65

Vinnl opened this issue Jan 30, 2017 · 5 comments

Comments

@Vinnl
Copy link
Contributor

Vinnl commented Jan 30, 2017

Currently, when using Webpack Dev Server with hot reloading, not adhering to my stylelist rules results in an error. The dev server then thinks compilation has failed and will not serve the updated styles.

I want to adhere to my linting rules, but perhaps not as strictly when I'm just messing about locally :) Thus, an option like ts-loader's emitErrors would be nice, that can set stylelint errors to be emitted as warnings.

Vinnl added a commit to Vinnl/stylelint-webpack-plugin that referenced this issue Jan 30, 2017
This option allows you to log errors as warnings, preventing
Webpack dev server from aborting compilation.
@Vinnl
Copy link
Contributor Author

Vinnl commented Jan 30, 2017

I went ahead and created a PR for this: #66. Let me know if that looks OK :)

@matthlavacka
Copy link

👍

Vinnl added a commit to Vinnl/stylelint-webpack-plugin that referenced this issue Feb 1, 2017
This option allows you to log errors as warnings, preventing
Webpack dev server from aborting compilation.
@adrienharnay
Copy link

Hi, very nice feature, I am looking forward to it! 👍

Vinnl added a commit to Vinnl/stylelint-webpack-plugin that referenced this issue Feb 13, 2017
This option allows you to log errors as warnings, preventing
Webpack dev server from aborting compilation.
@JaKXz JaKXz closed this as completed in a2e5a6d Feb 20, 2017
@JaKXz
Copy link
Contributor

JaKXz commented Feb 20, 2017

Thanks @Vinnl for getting the work in on this :)

@mhlavacka @Zephir77167 and others, if you could try installing stylelint-webpack-plugin#master and kicking the tires that would be great! I'll be releasing a new version soon.

@Vinnl
Copy link
Contributor Author

Vinnl commented Feb 20, 2017

For those who also never installed an NPM package directly from a repo before, you can simply run npm install JaKXz/stylelint-webpack-plugin#master.

It appears to work fine for me. I did encounter a strange thing that I reported in the PR #66, but I suppose that's probably a new issue?

joshwiens pushed a commit that referenced this issue Mar 31, 2018
Resolves #65.

This option allows you to log errors as warnings, preventing webpack-dev-server from aborting compilation.

* tests: fix typo in lint-dirty-modules test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants