Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: minimum supported Node.js version is 18 #345

Merged
merged 3 commits into from
Jan 26, 2024
Merged

build!: minimum supported Node.js version is 18 #345

merged 3 commits into from
Jan 26, 2024

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Minimum supported Node.js version is 18

Breaking Changes

Yes

Additional Info

No

@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdb0ab2) 100.00% compared to head (2c175bd) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          256       256           
  Branches        50        50           
=========================================
  Hits           256       256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardogobbosouza ricardogobbosouza force-pushed the chore-update-deps branch 2 times, most recently from 8dfc91e to 4054566 Compare January 25, 2024 13:44
@ricardogobbosouza ricardogobbosouza changed the title build!: minimum supported Node.js version is 18 build!: minimum supported node.js version is 18 Jan 25, 2024
@ricardogobbosouza ricardogobbosouza changed the title build!: minimum supported node.js version is 18 build!: minimum supported Node.js version is 18 Jan 25, 2024
@ricardogobbosouza
Copy link
Collaborator Author

ricardogobbosouza commented Jan 25, 2024 •
edited
Loading

The error that occurs in ci is that the action wagoid/commitlint-github-action@v5 is not using the latest version of @commitlint/lint

The latest version added a new rule header-trim
https://github.com/conventional-changelog/commitlint/releases/tag/v18.6.0

@alexander-akait
Copy link
Member

The error that occurs in ci is that the action wagoid/commitlint-github-action@v5 is not using the latest version of @commitlint/lint

Ignore it

alexander-akait
alexander-akait reviewed Jan 26, 2024
View reviewed changes
babel.config.js Outdated
@@ -10,7 +10,7 @@ module.exports = (api) => {
'@babel/preset-env',
{
targets: {
node: '14.15.0',
node: '18.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node: "18.12.0",

alexander-akait
alexander-akait reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the first LTS version

@alexander-akait
Copy link
Member

@ricardogobbosouza do you have premission to setup Github Actions?

@ricardogobbosouza
Copy link
Collaborator Author

@ricardogobbosouza do you have premission to setup Github Actions?

Yes I have.

@ricardogobbosouza ricardogobbosouza merged commit 1ee4588 into master Jan 26, 2024
31 of 32 checks passed
@ricardogobbosouza ricardogobbosouza deleted the chore-update-deps branch January 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardogobbosouza @alexander-akait